chore: 🏗️ add variable-resource map for prescreening form - #222
lwjohnst86 wants to merge 1 commit into
Conversation
2fe0006 to
174b85b
Compare
| medications,,canagliflozin_dose_v1,,visit_01,besg_1_screening, | ||
| medications,,candesartan_dose_v1,,visit_01,besg_1_screening, | ||
| admin,cgm_info_v1_admin,cgm_info_v1,,visit_01,besg_1_screening, | ||
| qc,cgm_no_qc,cgm_no_v1,,visit_01,besg_1_screening, |
There was a problem hiding this comment.
| qc,cgm_no_qc,cgm_no_v1,,visit_01,besg_1_screening, | |
| qc,cgm_no_v1_qc,cgm_no_v1,,visit_01,besg_1_screening, |
There are a lot of CGMs in this study, we'll need to know which one it is.
There was a problem hiding this comment.
We'll be rearranging these into long format (with visit number as a column), so this _v* tag isn't necessary. Plus, this is QC, which for now we are not including in the data package.
| qc,cgm_no_qc,cgm_no_v1,,visit_01,besg_1_screening, | ||
| admin,cgm_v1_admin,cgm_v1,,visit_01,besg_1_screening, | ||
| admin,cgmreader_v1_admin,cgmreader_v1,,visit_01,besg_1_screening, | ||
| admin,comment_blood_sample_v1_admin,comment_blood_sample_v1,,visit_01,besg_1_screening, |
There was a problem hiding this comment.
Not sure this should be admin, it is a full text description of why there may be outlier data regarding samples etc.
There was a problem hiding this comment.
Yea, there's a lot of variables I tagged with admin, but could also be qc. This one I can change to QC. But keep in mind, admin and QC resources won't go into this data package, as they aren't relevant from a research point of view. A researcher's job shouldn't be to figure out why data is missing or not, they should just know that if data is missing, there's a reason for it, it isn't random/a mistake. Our job as the engineers/builders of data packages is to make sure the data is high-quality enough that researchers can use it to answer their research questions effectively.
| admin,cgm_v1_admin,cgm_v1,,visit_01,besg_1_screening, | ||
| admin,cgmreader_v1_admin,cgmreader_v1,,visit_01,besg_1_screening, | ||
| admin,comment_blood_sample_v1_admin,comment_blood_sample_v1,,visit_01,besg_1_screening, | ||
| admin,comments_end_v1_admin,comments_end_v1,,visit_01,besg_1_screening, |
There was a problem hiding this comment.
This is the field they use for describing anything that happened during or before the visit, I expect some of the qualitative analysis would like these for reference.
| admin,compliance_risk_expl_v1_admin,compliance_risk_expl_v1,,visit_01,besg_1_screening, | ||
| admin,compliance_risk_v1_admin,compliance_risk_v1,,visit_01,besg_1_screening, |
There was a problem hiding this comment.
These two talks about any concerns that the study team may have regarding compliance with the protocol, not sure this is admin or should be study data.
| admin,psychiatric_disease_barrier_reason_v1_admin,psychiatric_disease_barrier_reason_v1,,visit_01,besg_1_screening, | ||
| admin,psychiatric_disease_barrier_v1_admin,psychiatric_disease_barrier_v1,,visit_01,besg_1_screening, |
There was a problem hiding this comment.
This is where they detail if a participant fails screening on psychiatric reasons. Probably not strictly speaking research data on such a small population, but I'm not entirely sure it is admin either.
| blood,,cpeptid_value_v1,,visit_01,besg_1_screening, | ||
| health_conditions,controlled_cvd,cvd_v1,,visit_01,besg_1_screening, | ||
| medications,,dapagliflozin_dose_v1,,visit_01,besg_1_screening, | ||
| *,,date_v1,,visit_01,besg_1_screening,Not sure how to include this in multiple resources... |
There was a problem hiding this comment.
if it is detailed in the overall ID table then if the fields have an identifier (like _v1) we could get the date from the ID table, and not from here?
K-Beicher
left a comment
K-Beicher
left a comment
There was a problem hiding this comment.
A few comments but overall looks good.
github-project-automation
Bot
moved this from In Review
to In Progress
in Data development
| blood,,cpeptid_value_v1,,visit_01,besg_1_screening, | ||
| health_conditions,controlled_cvd,cvd_v1,,visit_01,besg_1_screening, | ||
| medications,,dapagliflozin_dose_v1,,visit_01,besg_1_screening, | ||
| *,,date_v1,,visit_01,besg_1_screening,Not sure how to include this in multiple resources... |
There was a problem hiding this comment.
Independently of Kris' comment, just based on this table, what about having a row for each resource it should go in?
There was a problem hiding this comment.
Hmm, that's an idea 🤔
| medications,,thiazid_type_v1,,visit_01,besg_1_screening, | ||
| medications,,tirzepatid_dose_v1,,visit_01,besg_1_screening, | ||
| admin,training_notes_v1_admin,training_notes_v1,,visit_01,besg_1_screening, | ||
| medications,,treatment_v1,,visit_01,besg_1_screening, |
There was a problem hiding this comment.
treatment_v1 is a checkbox field. In the data this is given as one column for each checkbox option: treatment_v1___1, treatment_v1___2, treatment_v1___3.
How should we handle checkbox fields? Should we match the data and list each option in a separate row? This would be analogous to the checkbox expansion we have been doing so far. It would be more work upfront but it would make it possible to select these columns directly from the raw data when creating the resource.
This branch has not been deployed
3 participants
Description
Add variable to resource mapping for the prescreening form. This one is longer and more work to review.
Needs a thorough review.