chore: 🏗️ add variable-resource map for adverse events - #220
lwjohnst86 wants to merge 1 commit into
Conversation
a1879a8 to
56a1b69
Compare
There was a problem hiding this comment.
To make sure I understand, this is a table that for each raw field gives:
- the resource it will go in
- its name in the raw data
- its name in the staged data
- the abbreviation of the raw form it is from
- the name of the raw form it is from
I don’t understand the new_form_name column — why would a form ever be renamed? Aren’t forms the raw thing and resources the processed thing?
There was a problem hiding this comment.
Those are a remnant of the work Signe and I did with noting down what the new name should be in Main. You can ignore those I think.
There was a problem hiding this comment.
Ah okay! But then should that column be removed / moved to a separate table?
There was a problem hiding this comment.
Yes, for sure, good catch. We don't actually need that column anymore. Will remove 👍
There was a problem hiding this comment.
I'll remove those after all the other stacked PRs have been reviewed, approved and merged.
K-Beicher
left a comment
K-Beicher
left a comment
There was a problem hiding this comment.
Happy with these, the entire form may be dropped in main.
K-Beicher
left a comment
K-Beicher
left a comment
There was a problem hiding this comment.
Looks good, agree on that last one.
This branch has not been deployed
3 participants
Description
First part of this mapping. Will make PRs as I add mappings.
Needs a quick review.