Skip to content

Follow-up questions about source-dictionary.csv #183

Description

@signekb

I'm currently going through the source-dictionary.csv with new and old field and form names to get an overview of how they are named - and how we would like them to be named in the main study.

I've stumbled upon the following questions, some higher level and some specific to a field or form. Maybe @K-Beicher has some insights on the field specific ones in particular.

Higher-level questions:

  1. Should we change the _dq (data quality) suffix to _qc (quality control)? @lwjohnst86 mentioned that "qc" is more commonly used.
  2. Do we want visit and/or weeks (or phases?) (see Write a doc on weeks vs visits vs events dmp#220) in the field names or the form names - or both?
  3. Should we align numbering, so we always don't have a "_" before? E.g., currently we have v1, phase3, but e.g., group_meeting_8 and diet_consult_1.
  4. Should all field and form names be English? We e.g., currently have "stamdata", "randomisering", "individuel_ditistsamtale_1", and "hba1c_uge_30" (Danish) as form names.
  5. Do we want to make some explicit conventions about the usage of abbreviations in field and form names? E.g.,
  6. Should we remove parts of field names related to the form, or are they needed to avoid duplicate field names? E.g., bed_q_1 comes from binge_eating_disorder_questionnaire and ae_report_date comes from adverse_events.
    • 6.1. If they are needed, should we align so that the field names include the actual form name, so it's easier to remove computationally?
  7. Related to the above, should all field names have descriptive names, e.g., avoid bed_q_1 and use something like excessive_overeating_episodes?

Field- (and form-) specific questions:

  1. There's some fields called adminribe, is that supposed to be admin? E.g., cognition_deviation_adminribe_v10.
  2. What does admin2, admin3, etc. mean? E.g., cgm_reader_admin2_admin, excluded_note_admin0_admin and book_bloodsample_admin4?
  3. There's a field called t2d_duration_v01 under the prescreening_phone form. There's also a hidden field called t2d_duration_v0. I'm wondering if _v01 is supposed to be _v0 here but the 1 got added to avoid a duplicate name?
  4. Some field's are named tabac_, e.g., tabac_e_cigarettes.Is that intentional or should it be tobacco?
  5. Currently, there's only fields from one questionnaire with a phase suffix, e.g., the field date_exercise_deviation_phase3 from the exercise_deviation form. These are all phase3 - should we have phases on other fields and/or forms?
  6. There's some forms named pre_visit_0X_admin, e.g., pre_visit_01_admin. How do we map them onto a visit or week?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions