odoo-java · flotho · Jul 9, 2024 · May 31, 2024 · May 31, 2024 · May 31, 2024
diff --git a/.gitignore b/.gitignore
@@ -3,7 +3,8 @@
 /bin/
 /target/
 
-# Eclipse stuff
+# IDE stuff
+.vscode
 .project
 .classpath
 .settings/
@@ -20,4 +21,4 @@ nbactions.xml
 nbproject/
 
 # OS stuff
-.directory
+.directory
diff --git a/.vscode/settings.json b/.vscode/settings.json
diff --git a/pom.xml b/pom.xml
@@ -5,7 +5,7 @@
 
     <groupId>com.odoojava</groupId>
     <artifactId>odoo-java-api</artifactId>
-    <version>3.3.3</version>
+    <version>3.3.4</version>
     <packaging>jar</packaging>
 
     <name>odoo-java-api</name>

diff --git a/src/main/java/com/odoojava/api/OdooCommand.java b/src/main/java/com/odoojava/api/OdooCommand.java
@@ -76,10 +76,26 @@ public Response searchObject(String objectName, Object[] filter, int offset, int
         Object offsetParam = offset < 0 ? false : offset;
         Object limitParam = limit < 0 ? false : limit;
         Object orderParam = order == null || order.length() == 0 ? false : order;
+
+        // TODO: Need a big refactor because it become difficult to maintain
+        // strategy, work with interface and factory to make the call generic in our lib and 
+        // have specific class for eash version 
+
+        // default version v17  : https://github.com/odoo/odoo/blob/17.0/odoo/models.py#L1594
+        // no more count parameter in the search
+        Object[] params = new Object[] { filter, offsetParam, limitParam, orderParam };
+
+
+        if (this.session.getServerVersion().getMajor() < 10){
+        // Before Odoo 10 there's a 'context' parameter between order and count
+            params = new Object[] { filter, offsetParam, limitParam, orderParam, session.getContext(), count };
+        }
+        if (this.session.getServerVersion().getMajor() >= 10 &&
+                this.session.getServerVersion().getMajor() < 17){
         // Before Odoo 10 there's a 'context' parameter between order and count
-        Object[] params = (this.session.getServerVersion().getMajor() < 10)
-                ? new Object[] { filter, offsetParam, limitParam, orderParam, session.getContext(), count }
-                : new Object[] { filter, offsetParam, limitParam, orderParam, count };
+            params = new Object[] { filter, offsetParam, limitParam, orderParam, count };
+        }
+
 
         try {
             // TODO: test differents version with search on quantity on products

diff --git a/src/main/java/com/odoojava/api/Row.java b/src/main/java/com/odoojava/api/Row.java
@@ -67,7 +67,19 @@ public int getID(){
 		Object idValue = get("id");
 		return Integer.parseInt(idValue.toString());
 	}
-
+
+    /**
+    * Returns the database string field of the object/row.
+    * @return string
+    */
+    public String getString(String fieldName){
+        String res=null;
+        if ( get(fieldName)!= null){
+            res = get(fieldName).toString();
+        }
+        return res;
+    }
+
 	/**
 	 * Add a listener to be notified when a row is being changed
 	 * @param listener

diff --git a/src/main/java/com/odoojava/api/Session.java b/src/main/java/com/odoojava/api/Session.java
@@ -182,8 +182,8 @@ public void startSession() throws Exception {
 
 	private void checkVersionCompatibility() throws XmlRpcException, OdooApiException {
 
-		if (this.getServerVersion().getMajor() < 8 || this.getServerVersion().getMajor() > 16) {
-			throw new OdooApiException("Only Odoo Version from v8.x to 16.x are maintained. "
+		if (this.getServerVersion().getMajor() < 8 || this.getServerVersion().getMajor() > 17) {
+			throw new OdooApiException("Only Odoo Version from v8.x to 17.x are maintained. "
 					+ "Please choose another version of the library");
 		}
 	}