Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
0f4da15
REF: Make `Service.send_exception` private
cortadocodes May 30, 2025
29f1b4c
MRG: Merge branch 'main' into return-outputs-on-exception
cortadocodes May 30, 2025
890382d
FEA: Send result event for failed analyses
cortadocodes May 30, 2025
921cb0f
FIX: Fix analysis attribute setting
cortadocodes May 30, 2025
af59521
TST: Fix `make_new_child`
cortadocodes May 30, 2025
0790317
FIX: Prepare analysis object properly in runner
cortadocodes Jun 10, 2025
e8145ce
TST: Update service tests
cortadocodes Jun 10, 2025
8124e65
FIX: Avoid sending `Analysis` kwargs to superclasses
cortadocodes Jun 10, 2025
6e24ea4
TST: Simplify `make_run_function`
cortadocodes Jun 10, 2025
9caa15f
TST: Update child tests
cortadocodes Jun 10, 2025
2eee569
ENH: Allow not raising errors from exception events in event handler
cortadocodes Jun 10, 2025
7536ef8
ENH: Add `success` key to result events
cortadocodes Jun 14, 2025
707e403
REF: Factor out converting exception event to exception
cortadocodes Jun 14, 2025
1fccf23
ENH: Add exception to result event if success is `False`
cortadocodes Jun 14, 2025
ec63c50
ENH: Trigger question retries in `Child` if result `success=False`
cortadocodes Jun 14, 2025
c8b1d63
ENH: Add `raise_errors` option to `Service.wait_for_answer`
cortadocodes Jun 14, 2025
8cb5400
REF: Simplify handling of `analysis` in `Service.answer`
cortadocodes Jun 14, 2025
87e05c9
REF: Move private method further down class
cortadocodes Jun 14, 2025
3fbff4e
FIX: Avoid raising errors in child's first question attempt
cortadocodes Jun 14, 2025
00460a3
FIX: Update exception handling in `Child.ask`
cortadocodes Jun 14, 2025
ddbb536
DOC: Update docstrings
cortadocodes Jun 14, 2025
f8b63bc
FIX: Ensure full result event is returned from event handler
cortadocodes Jun 14, 2025
456e014
TST: Update test
cortadocodes Jun 14, 2025
0e2a215
REV: Revert "FIX: Ensure full result event is returned from event han…
cortadocodes Jun 14, 2025
e9baa4f
FIX: Add `success` key to result returned from event handler
cortadocodes Jun 14, 2025
13a4ed4
FIX: Add `result` key to result returned from event handler
cortadocodes Jun 14, 2025
7522472
REF: Remove extra whitespace
cortadocodes Jun 14, 2025
99c9cdc
TST: Update tests
cortadocodes Jun 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DOC: Update docstrings
  • Loading branch information
cortadocodes committed Jun 14, 2025
commit ddbb536f1f0115aee45471127d735a1c0d94707f
2 changes: 1 addition & 1 deletion octue/cloud/pub_sub/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def wait_for_answer(
:param float|int maximum_heartbeat_interval: the maximum amount of time (in seconds) allowed between child heartbeats before an error is raised
:param bool raise_errors:
:raise TimeoutError: if the timeout is exceeded
:return dict: dictionary containing the keys "output_values" and "output_manifest"
:return dict: dictionary containing the keys "output_values", "output_manifest", "success", and for a failed analysis, "exception"
"""
if subscription.is_push_subscription:
raise octue.exceptions.NotAPullSubscription(
Expand Down
2 changes: 1 addition & 1 deletion octue/resources/child.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def ask(
:param float|int maximum_heartbeat_interval: the maximum amount of time (in seconds) allowed between child heartbeats before an error is raised
:raise TimeoutError: if the timeout is exceeded while waiting for an answer
:raise Exception: if the question raises an error and `raise_errors=True`
:return dict|octue.cloud.pub_sub.subscription.Subscription|Exception|None, str: for a synchronous question, a dictionary containing the keys "output_values" and "output_manifest" from the result (or just an exception if the question fails), and the question UUID; for a question with a push endpoint, the push subscription and the question UUID; for an asynchronous question, `None` and the question UUID
:return dict|octue.cloud.pub_sub.subscription.Subscription|Exception|None, str: for a synchronous question, a dictionary containing the keys "output_values", "output_manifest", and "success" from the result (or just an exception if the question fails), and the question UUID; for a question with a push endpoint, the push subscription and the question UUID; for an asynchronous question, `None` and the question UUID
"""
prevent_retries_when = prevent_retries_when or []

Expand Down