Skip to content
This repository was archived by the owner on Apr 21, 2022. It is now read-only.

feat: adding region, sslEnabled and s3ForcePathStyle through env vars - #98

Closed
ArchangelX360 wants to merge 3 commits into
oclif:masterfrom
ArchangelX360:master
Closed

feat: adding region, sslEnabled and s3ForcePathStyle through env vars#98
ArchangelX360 wants to merge 3 commits into
oclif:masterfrom
ArchangelX360:master

Conversation

@ArchangelX360

Copy link
Copy Markdown
Contributor

Following the implementation choice of 2ce9b39, I added the support for specific region, sslEnabled and s3ForcePathStyle configuration values.

We should consider supporting the entire ClientConfiguration object potentially through package.json configuration, hence modifying oclif-config project.

@salesforce-cla

salesforce-cla Bot commented Apr 8, 2019

Copy link
Copy Markdown

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Titouan Bion <t***@b***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@codecov

codecov Bot commented Apr 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   35.22%   35.22%           
=======================================
  Files          19       19           
  Lines         687      687           
  Branches      118      118           
=======================================
  Hits          242      242           
  Misses        416      416           
  Partials       29       29
Impacted Files Coverage Δ
src/aws.ts 19.51% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fddd31d...e5f06a2. Read the comment docs.

@salesforce-cla

salesforce-cla Bot commented Apr 8, 2019

Copy link
Copy Markdown

Thanks for the contribution! Unfortunately we can't verify the commit author(s): ArchangelX360 <b***@g***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@salesforce-cla

salesforce-cla Bot commented Apr 8, 2019

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @ArchangelX360 to sign the Salesforce.com Contributor License Agreement.

@ArchangelX360

Copy link
Copy Markdown
Contributor Author

Any news on that?

@ArchangelX360

Copy link
Copy Markdown
Contributor Author

I got a GPG issue on the CircleCI pipeline, I would need help resolving it. Anyone knows how to resolve this?

@RasPhilCo

Copy link
Copy Markdown
Contributor

@ArchangelX360 Can you move this to a non-master branch? (tl;dr - we have to run a script to test 3rd party commits with secrets and they can't be on master)

@ArchangelX360

Copy link
Copy Markdown
Contributor Author

Opened on a non-master branch in #280

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants