This repository was archived by the owner on Apr 21, 2022. It is now read-only.
feat: adding region, sslEnabled and s3ForcePathStyle through env vars - #280
Merged
Conversation
RasPhilCo
approved these changes
Dec 10, 2020
Contributor
Author
|
Thanks 🙏! I cannot merge as I have insufficient rights so feel free to! |
oclif-bot
added a commit
that referenced
this pull request
Dec 10, 2020
# [1.26.0](v1.25.1...v1.26.0) (2020-12-10) ### Features * adding region, sslEnabled and s3ForcePathStyle through env vars ([#280](#280)) ([9a31738](9a31738))
Contributor
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened in a non-master branch as asked on #98
Following the implementation choice of 2ce9b39, I added the support for specific
region,sslEnabledands3ForcePathStyleconfiguration values.We should consider supporting the entire
ClientConfigurationobject potentially throughpackage.jsonconfiguration, hence modifying oclif-config project.