fix: rename oclif manifest to not be a dotfile

jdx · jdx · commit 6fb3dc63050b · 2018-05-02T20:56:13.000-07:00
diff --git a/package.json b/package.json
@@ -8,9 +8,9 @@
   },
   "bugs": "https://github.com/oclif/dev-cli/issues",
   "dependencies": {
-    "@oclif/command": "^1.4.18",
-    "@oclif/config": "^1.6.16",
-    "@oclif/errors": "^1.0.7",
+    "@oclif/command": "^1.4.19",
+    "@oclif/config": "^1.6.17",
+    "@oclif/errors": "^1.0.8",
     "@oclif/plugin-help": "^1.2.7",
     "cli-ux": "^3.4.1",
     "debug": "^3.1.0",
@@ -23,7 +23,7 @@
   },
   "devDependencies": {
     "@oclif/plugin-legacy": "^1.0.13",
-    "@oclif/test": "^1.0.5",
+    "@oclif/test": "^1.0.6",
     "@oclif/tslint": "^1.1.0",
     "@types/chai": "^4.1.3",
     "@types/execa": "^0.9.0",
@@ -32,10 +32,10 @@
     "@types/lodash": "^4.14.108",
     "@types/lodash.template": "^4.4.3",
     "@types/mocha": "^5.2.0",
-    "@types/node": "^10.0.2",
+    "@types/node": "^10.0.3",
     "@types/supports-color": "^5.3.0",
     "@types/write-json-file": "^2.2.1",
-    "aws-sdk": "^2.230.1",
+    "aws-sdk": "^2.231.1",
     "chai": "^4.1.2",
     "globby": "^8.0.1",
     "mocha": "^5.1.1",
@@ -47,7 +47,7 @@
     "node": ">=8.0.0"
   },
   "files": [
-    ".oclif.manifest.json",
+    "oclif.manifest.json",
     "/bin",
     "/lib"
   ],
@@ -85,7 +85,7 @@
   "repository": "oclif/dev-cli",
   "scripts": {
     "lint": "tsc -p test --noEmit && tslint -p test -t stylish",
-    "postpack": "rm -f .oclif.manifest.json",
+    "postpack": "rm -f oclif.manifest.json",
     "posttest": "tsc -p test --noEmit && tslint -p test -t stylish",
     "prepack": "rm -rf lib && tsc && node ./bin/run manifest",
     "test": "mocha --forbid-only \"test/**/*.test.ts\"",
diff --git a/src/commands/manifest.ts b/src/commands/manifest.ts
@@ -2,7 +2,7 @@
 
 import {Command} from '@oclif/command'
 import * as Config from '@oclif/config'
-import * as fs from 'fs'
+import * as fs from 'fs-extra'
 import * as path from 'path'
 
 export default class Manifest extends Command {
@@ -12,7 +12,7 @@ export default class Manifest extends Command {
   ]
 
   async run() {
-    try { fs.unlinkSync('.oclif.manifest.json') } catch {}
+    try { fs.unlinkSync('oclif.manifest.json') } catch {}
     const {args} = this.parse(Manifest)
     const root = path.resolve(args.path)
     let plugin = new Config.Plugin({root, type: 'core', ignoreManifest: true, errorOnManifestCreate: true})
@@ -29,8 +29,13 @@ export default class Manifest extends Command {
     if (process.env.OCLIF_NEXT_VERSION) {
       plugin.manifest.version = process.env.OCLIF_NEXT_VERSION
     }
-    const file = path.join(plugin.root, '.oclif.manifest.json')
+    const file = path.join(plugin.root, 'oclif.manifest.json')
     fs.writeFileSync(file, JSON.stringify(plugin.manifest))
+    if (this.config.pjson.files.includes('.oclif.manifest.json')) {
+      const pjson = await fs.readJSON('package.json')
+      pjson.files = pjson.files.map((f: string) => f === '.oclif.manifest.json' ? 'oclif.manifest.json' : f)
+      await fs.outputJSON('package.json', pjson, {spaces: 2})
+    }
     this.log(`wrote manifest to ${file}`)
   }
 }
diff --git a/test/manifest.test.ts b/test/manifest.test.ts
@@ -5,14 +5,14 @@ import * as fs from 'fs-extra'
 describe('manifest', () => {
   test
   .stdout()
-  .do(() => fs.remove('.oclif.manifest.json'))
-  .finally(() => fs.remove('.oclif.manifest.json'))
+  .do(() => fs.remove('oclif.manifest.json'))
+  .finally(() => fs.remove('oclif.manifest.json'))
   .command(['manifest'])
   .it('outputs plugins', ctx => {
-    const {commands} = fs.readJSONSync('.oclif.manifest.json') as Config.Manifest
+    const {commands} = fs.readJSONSync('oclif.manifest.json') as Config.Manifest
     expect(commands.manifest).to.include({
       description: 'generates plugin manifest json'
     })
-    expect(ctx.stdout).to.match(/wrote manifest to .*\.oclif.manifest.json/)
+    expect(ctx.stdout).to.match(/wrote manifest to .*oclif.manifest.json/)
   })
 })
diff --git a/yarn.lock b/yarn.lock
@@ -54,9 +54,18 @@
     debug "^3.1.0"
     semver "^5.5.0"
 
-"@oclif/config@^1.6.16":
-  version "1.6.16"
-  resolved "https://registry.yarnpkg.com/@oclif/config/-/config-1.6.16.tgz#6bcb03bf30ee54eeafa788777d965bf47bb5047d"
+"@oclif/command@^1.4.19":
+  version "1.4.19"
+  resolved "https://registry.yarnpkg.com/@oclif/command/-/command-1.4.19.tgz#7158eec97d9b4c4a109181e6a71bd83d34757254"
+  dependencies:
+    "@oclif/errors" "^1.0.6"
+    "@oclif/parser" "^3.3.3"
+    debug "^3.1.0"
+    semver "^5.5.0"
+
+"@oclif/config@^1.6.17":
+  version "1.6.17"
+  resolved "https://registry.yarnpkg.com/@oclif/config/-/config-1.6.17.tgz#e9608f56e5acd49fcaf3bbfcc3e8818d81b1ba12"
   dependencies:
     debug "^3.1.0"
 
@@ -70,9 +79,9 @@
     strip-ansi "^4.0.0"
     wrap-ansi "^3.0.1"
 
-"@oclif/errors@^1.0.7":
-  version "1.0.7"
-  resolved "https://registry.yarnpkg.com/@oclif/errors/-/errors-1.0.7.tgz#13d7205801944c341534370e65140d21ab929e24"
+"@oclif/errors@^1.0.8":
+  version "1.0.8"
+  resolved "https://registry.yarnpkg.com/@oclif/errors/-/errors-1.0.8.tgz#2f8239267506bb7c3f5fd776144c2686e5b7fff7"
   dependencies:
     clean-stack "^1.3.0"
     fs-extra "^6.0.0"
@@ -118,11 +127,11 @@
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/@oclif/screen/-/screen-1.0.2.tgz#c9d7c84b0ea60ecec8dd7a9b22c012ba9967aed8"
 
-"@oclif/test@^1.0.5":
-  version "1.0.5"
-  resolved "https://registry.yarnpkg.com/@oclif/test/-/test-1.0.5.tgz#2b8e8384148a75c6cc6ef20df54cfa55cde15d4e"
+"@oclif/test@^1.0.6":
+  version "1.0.6"
+  resolved "https://registry.yarnpkg.com/@oclif/test/-/test-1.0.6.tgz#45dbab5610caed9f178e33ff6b416f6ce2dc245c"
   dependencies:
-    fancy-test "^1.0.5"
+    fancy-test "^1.0.6"
 
 "@oclif/tslint@^1.1.0":
   version "1.1.0"
@@ -186,9 +195,9 @@
   version "8.10.11"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-8.10.11.tgz#971ea8cb91adbe0b74e3fbd867dec192d5893a5f"
 
-"@types/node@^10.0.2":
-  version "10.0.2"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-10.0.2.tgz#180046ebbc37de8b64777765c2486ebecb59448e"
+"@types/node@^10.0.3":
+  version "10.0.3"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-10.0.3.tgz#1f89840c7aac2406cc43a2ecad98fc02a8e130e4"
 
 "@types/supports-color@^5.3.0":
   version "5.3.0"
@@ -272,9 +281,9 @@ atob@^2.0.0:
   version "2.1.1"
   resolved "https://registry.yarnpkg.com/atob/-/atob-2.1.1.tgz#ae2d5a729477f289d60dd7f96a6314a22dd6c22a"
 
-aws-sdk@^2.230.1:
-  version "2.230.1"
-  resolved "https://registry.yarnpkg.com/aws-sdk/-/aws-sdk-2.230.1.tgz#494cef6aed2e16db1ed9c12acf4bd2a7317f5365"
+aws-sdk@^2.231.1:
+  version "2.231.1"
+  resolved "https://registry.yarnpkg.com/aws-sdk/-/aws-sdk-2.231.1.tgz#ff0a63f73c71b6b098389b926b857b13816bd5f9"
   dependencies:
     buffer "4.9.1"
     events "1.1.1"
@@ -689,11 +698,11 @@ extract-stack@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/extract-stack/-/extract-stack-1.0.0.tgz#b97acaf9441eea2332529624b732fc5a1c8165fa"
 
-fancy-test@^1.0.5:
-  version "1.0.5"
-  resolved "https://registry.yarnpkg.com/fancy-test/-/fancy-test-1.0.5.tgz#323970de576f7dc0938402c3a731ee4d59896a11"
+fancy-test@^1.0.6:
+  version "1.0.6"
+  resolved "https://registry.yarnpkg.com/fancy-test/-/fancy-test-1.0.6.tgz#e0a061ecdcfb9d8fbea1f86375ed26e258ed7243"
   dependencies:
-    lodash "^4.17.5"
+    lodash "^4.17.10"
     stdout-stderr "^0.1.9"
 
 fast-glob@^2.0.2:
