Repository navigation
Fix issue #63: IN clause datatype mismatch with JSON-encoded lists - #64
Merged
Merged
Conversation
Remove automatic list JSON-encoding from encode_param function. This fixes the datatype mismatch error when using IN clauses with parameterized lists. The issue occurred because lists were being JSON-encoded to strings, causing SQLite to see them as JSON strings instead of individual values. Key changes: - Lists are no longer automatically JSON-encoded in encode_param - Ecto's query builder properly expands IN clause parameters at the SQL generation level - Ecto dumpers handle JSON encoding for array fields in schemas - Raw SQL queries with array fields should pre-encode lists using Jason.encode! This allows proper IN clause expansion while maintaining support for array fields through schema dumpers and explicit pre-encoding in raw SQL queries. Updated tests to pre-encode lists when using raw SQL with array fields.
Contributor
WalkthroughThis change removes automatic JSON encoding of lists in query parameters, allowing them to be passed unchanged. Ecto's IN clause expansion and schema field dumpers now handle list encoding appropriately based on context. Changes
Possibly related issues
Poem
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove automatic list JSON-encoding from encode_param function.
This fixes the datatype mismatch error when using IN clauses with parameterised lists. The issue occurred because lists were being JSON-encoded to strings, causing SQLite to see them as JSON strings instead of individual values.
Key changes:
This allows proper IN clause expansion while maintaining support for array fields through schema dumpers and explicit pre-encoding in raw SQL queries.
Updated tests to pre-encode lists when using raw SQL with array fields.
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.