This repository was archived by the owner on Oct 23, 2024. It is now read-only.
instance settings#35
Merged
Merged
Conversation
Contributor
Author
|
@codenamekt I have no clue why the coverage guy spaced out before reporting back to github! |
keshavmagge
assigned
keshavmagge and
codenamekt and unassigned
codenamekt and
keshavmagge
Contributor
|
Looks like coverall settings was changed to leave status messages and there is no way to set github to not require certain status messages. There was no thresholds set which broke coveralls. So it saw 0% coverage but didn't know how to say pass or fail without any thresholds set. |
Contributor
|
+1 LGTM. Merging to override the failed status checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settings is now included in the instance details