feat: filter by operation ids#929
Merged
jamietanna merged 1 commit intooapi-codegen:masterfrom Jan 25, 2024
Merged
Conversation
johanneswuerbach
force-pushed
the
filter-by-operation-ids
branch
4 times, most recently
from
3198861 to
e678279
Compare
Contributor
Author
|
I would also appreciate a look here @deepmap-marcinr and sorry about the spam :-( This is the last one, promise :-) |
johanneswuerbach
force-pushed
the
filter-by-operation-ids
branch
from
e678279 to
7a85238
Compare
Contributor
Author
|
@deepmap-marcinr is this something, which would be acceptable for this repository? Happy to further elaborate on our use-case. |
Member
|
Hey @johanneswuerbach thanks for raising! Would you mind adding an example of the usage under Once done, I'd say we can merge 😁 |
johanneswuerbach
force-pushed
the
filter-by-operation-ids
branch
2 times, most recently
from
34efa3a to
255ac80
Compare
Contributor
Author
|
Thanks for the review @jamietanna , integration tests added 👍 |
Contributor
Author
|
@jamietanna anything else I can support here? Thank you 🙇 |
johanneswuerbach
force-pushed
the
filter-by-operation-ids
branch
from
255ac80 to
6f01e97
Compare
johanneswuerbach
force-pushed
the
filter-by-operation-ids
branch
from
6f01e97 to
0b43f56
Compare
Contributor
Author
|
@jamietanna I know you are busy, but I wondered if there is any chance to land this :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating server mocks or clients we often only need specific operations to be included. Right now we workaround this issue by having unique operation tags, but this has various side-effects.
Add the capability to include or exclude specific operations by their operation id inline with the existing support to filter by tags.