Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ help:
@echo " lint lint the project"

$(GOBIN)/golangci-lint:
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/main/install.sh | sh -s -- -b $(GOBIN) v2.13.2
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/main/install.sh | sh -s -- -b $(GOBIN) v2.14.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Existing linter stays outdated

If a contributor already has bin/golangci-lint from v2.13.2, make tools and make lint will keep using it: the install target has no prerequisites, so changing the recipe to v2.14.0 does not rerun it. This makes the upgrade ineffective for existing local installations. Please make the target version-aware or check the installed version.

Prompt To Fix With AI
This is a comment left during a code review.
Path: Makefile
Line: 13

Comment:
**Existing linter stays outdated**

If a contributor already has `bin/golangci-lint` from v2.13.2, `make tools` and `make lint` will keep using it: the install target has no prerequisites, so changing the recipe to v2.14.0 does not rerun it. This makes the upgrade ineffective for existing local installations. Please make the target version-aware or check the installed version.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.


.PHONY: tools
tools: $(GOBIN)/golangci-lint
Expand Down
Loading