Skip to content

Preserve union metadata when collapsing nullable wrappers #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
g-logunov wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Preserve union metadata when collapsing nullable wrappers #2566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions internal/test/aggregates/matrix/shapes/nested_nullable_union_31.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# From issue-2565: nested nullable unions must preserve JSON payloads.
versions: [v1, v2, v3]
description: 'A nested oneOf inside an OpenAPI 3.1 nullable anyOf preserves its union payload.'
openapi: 3.1.0
subject:
anyOf:
- oneOf:
- $ref: '#/components/schemas/Cat'
- $ref: '#/components/schemas/Dog'
- type: 'null'
components:
Cat:
type: object
required: [meow]
properties:
meow: {type: string}
Dog:
type: object
required: [bark]
properties:
bark: {type: string}
samples:
- '{"meow": "purr"}'
- '{"bark": "woof"}'
11 changes: 11 additions & 0 deletions internal/test/aggregates/matrix/v1/nested_nullable_union_31/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# yaml-language-server: $schema=../../../../../../configuration-schema.json
# Code generated by specgen from ../../shapes/nested_nullable_union_31.yaml. DO NOT EDIT.
package: matrixv1nestednullableunion31
output: nested_nullable_union_31.gen.go
generate:
models: true
client: true
std-http-server: true
strict-server: true
compatibility:
schema-merging-behavior: v1
14 changes: 14 additions & 0 deletions internal/test/aggregates/matrix/v1/nested_nullable_union_31/doc.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

234 changes: 234 additions & 0 deletions internal/test/aggregates/matrix/v1/nested_nullable_union_31/matrix_gen_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading