fix: support x-oapi-codegen-extra-tags on parameter schemas (#2232)#2235
Merged
mromaszewicz merged 1 commit intooapi-codegen:mainfrom Feb 24, 2026
Merged
fix: support x-oapi-codegen-extra-tags on parameter schemas (#2232)#2235mromaszewicz merged 1 commit intooapi-codegen:mainfrom
mromaszewicz merged 1 commit intooapi-codegen:mainfrom
Conversation
…egen#2232) When x-oapi-codegen-extra-tags was placed on the schema inside a parameter definition (rather than on the parameter itself), the extension was silently ignored. This happened because GenerateParamsTypes only read parameter-level extensions, not schema-level ones. Merge extensions from both the parameter and its schema when building the Params struct, with parameter-level extensions taking precedence. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
Required label not found on this PR. |
jamietanna
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When x-oapi-codegen-extra-tags was placed on the schema inside a parameter definition (rather than on the parameter itself), the extension was silently ignored. This happened because GenerateParamsTypes only read parameter-level extensions, not schema-level ones.
Merge extensions from both the parameter and its schema when building the Params struct, with parameter-level extensions taking precedence.