Skip to content

fix: set indentation to 2 when marshalling spec for overlay#2172

Merged
jamietanna merged 3 commits intooapi-codegen:mainfrom
wndhydrnt:fix-overlay-load-array-newline
Feb 16, 2026
Merged

fix: set indentation to 2 when marshalling spec for overlay#2172
jamietanna merged 3 commits intooapi-codegen:mainfrom
wndhydrnt:fix-overlay-load-array-newline

Conversation

@wndhydrnt
Copy link
Contributor

@wndhydrnt wndhydrnt commented Nov 27, 2025

Fixes #2171

This change is just a workaround for yaml/go-yaml#76.
The marshalling/unmarshalling is transparent to the user.
Changing the indentation shouldn't break anything.

@wndhydrnt wndhydrnt requested a review from a team as a code owner November 27, 2025 16:38
@mromaszewicz
Copy link
Member

Thanks. We'll merge once CI is fixed. Waiting on an approval to check that in.

@jamietanna jamietanna enabled auto-merge (squash) February 16, 2026 21:10
@jamietanna jamietanna added the bug Something isn't working label Feb 16, 2026
@jamietanna jamietanna disabled auto-merge February 16, 2026 21:11
@jamietanna jamietanna enabled auto-merge (squash) February 16, 2026 21:11
@jamietanna jamietanna merged commit 77bda89 into oapi-codegen:main Feb 16, 2026
27 checks passed
@wndhydrnt wndhydrnt deleted the fix-overlay-load-array-newline branch February 17, 2026 07:10
@wndhydrnt
Copy link
Contributor Author

Thank you for the review and the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modifying via overlay fails if an array item contains a field that starts with a newline

3 participants