Support unions with multiple mappings pointing to a single underlying type#2071
Merged
mromaszewicz merged 2 commits intooapi-codegen:mainfrom Feb 16, 2026
Merged
Support unions with multiple mappings pointing to a single underlying type#2071mromaszewicz merged 2 commits intooapi-codegen:mainfrom
mromaszewicz merged 2 commits intooapi-codegen:mainfrom
Conversation
Kusari Analysis Results:
No pinned version dependency changes, code issues or exposed secrets detected!
Found this helpful? Give it a 👍 or 👎 reaction! |
Contributor
Author
|
@jamietanna are you able to take a look at this one? |
Contributor
Author
|
@mromaszewicz are you able to take a look at this? |
mromaszewicz
approved these changes
Feb 16, 2026
Member
|
This looks good, I had to think about it for a while, since this code path is so fragile. Thanks for doing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1530
Fixes #1664
This PR:
ValueByDiscriminatorfunction when multiple discriminator values map to a single typeFrom*/Merge*functions from setting an arbitrary discriminator in the case where there isn't a 1:1 mapping between type and discriminator value