Skip to content

fix: follow-ups to #1957#1971

Draft
jamietanna wants to merge 1 commit intomainfrom
iss-1957
Draft

fix: follow-ups to #1957#1971
jamietanna wants to merge 1 commit intomainfrom
iss-1957

Conversation

@jamietanna
Copy link
Member

No description provided.

Copy link
Member Author

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd hoped that #1610 had fixed this, but unfortunately not - need to keep digging

@jamietanna
Copy link
Member Author

#1981 is required for this

@jamietanna
Copy link
Member Author

OK, the issue I'm trying to fix is that:

  • IsGoTypeReference needs to get called as part of the AllOf merging, but isn't - so we're calling valueWithPropagatedRef which then returns the value, not a $ref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant