feat(extension): add x-oapi-codegen-only-honour-go-name#1697
Merged
jamietanna merged 1 commit intomainfrom Jul 21, 2024
Merged
Conversation
Although originally to fix #1638, which isn't a very recommended approach as it may lead to a confusing behaviour for users, we can still add support. However, we should hide this behind both a global Compatibility Option, to ensure that it's clearly opted-in, as well as adding a per-field level to ensure that only the right fields are overridden. Closes #1638.
|
Got an ETA of a merge? |
Member
Author
|
(Merging as I had a bit of time this evening, not necessarily related to the bump) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although originally to fix #1638, which isn't a very recommended
approach as it may lead to a confusing behaviour for users, we can still
add support.
However, we should hide this behind both a global Compatibility Option,
to ensure that it's clearly opted-in, as well as adding a per-field
level to ensure that only the right fields are overridden.
Closes #1638.