MAINT: Cleanup ma.array.__str__ - #9768
Merged
Merged
Conversation
Working with 0d arrays is enough here
eric-wieser
force-pushed
the
ma-str-cleanup
branch
from
September 25, 2017 16:20
356341b to
91b83ac
Compare
This means that large void arrays are now truncated as they are for other types, for speed.
eric-wieser
force-pushed
the
ma-str-cleanup
branch
from
September 26, 2017 04:58
4e1f3f7 to
25c808c
Compare
Member
Author
|
Clumsy mistake first time around on that last commit. All passing now. |
Member
Author
|
Actually, this is a bugfix. Before (1.13): After Although part of that is probably the 0d scalar stuff, and that'll likely change again with #9332 |
mhvk
approved these changes
Sep 26, 2017
Member
|
@mhvk Feel free to merge ... |
Member
|
Give me a few minutes to finish looking at this.. I started yesterday but there are updates since then. |
ahaldane
reviewed
Sep 26, 2017
| for name in names: | ||
| (curdata, curmask) = (result[name], mask[name]) | ||
| if curdata.dtype.names: | ||
| if names: |
Member
There was a problem hiding this comment.
technically not necessary since this function is always called with names (or else the old code would fail). Fine to leave it.
Member
There was a problem hiding this comment.
OK, I get that this was intentional based on reorganization below.
Member
Author
|
Two approvals for a MAINT sounds like a good enough excuse to self-merge to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove hack from gh-7659 for gh-7493