Skip to content

ENH: Print object arrays containing lists unambiguously - #8989

Merged
charris merged 2 commits into
numpy:masterfrom
eric-wieser:object-repr
May 1, 2017
Merged

charris merged 2 commits into
numpy:masterfrom
eric-wieser:object-repr

Conversation

@eric-wieser

Copy link
Copy Markdown
Member

Previously

array([[1], [1, 1], [1, 1], [1]], dtype=object)

Now

array([list([1]), list([1, 1]), list([1, 1]), list([1])], dtype=object)

@ahaldane

Copy link
Copy Markdown
Member

+1 from me. Code LGTM.

@eric-wieser

Copy link
Copy Markdown
Member Author

Updated with a release note, that also includes an entry about #8963, since they're related

Comment thread numpy/core/arrayprint.py Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting fact - this is never nor was ever used...

@homu

homu commented May 1, 2017

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #8967) made this pull request unmergeable. Please resolve the merge conflicts.

@eric-wieser eric-wieser added this to the 1.13.0 release milestone May 1, 2017
@eric-wieser

Copy link
Copy Markdown
Member Author

Adding to the milestone since this contains a release note fix for an already-included feature

@charris
charris merged commit 9c3d247 into numpy:master May 1, 2017
@charris

charris commented May 1, 2017

Copy link
Copy Markdown
Member

Thanks Eric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants