[MRG]: Fweight and aweight support for np.var - #5930
Conversation
|
bump? |
There was a problem hiding this comment.
typo cobariance
|
☔ The latest upstream changes (presumably #4619) made this pull request unmergeable. Please resolve the merge conflicts. |
|
What is the status of this PR? |
hmm, this never got followed up on. The two types of weights are weird imho. Also in |
|
@rgommers IIRC, there was quite a long discussion about the two weights. |
|
maybe we can find it and document it properly then? it doesn't make too much sense right now imho ..... |
|
I can't find it with a quick search, but there was this, that tickles my memory. |
|
The previous discussion can be found here: #4960 |
|
So was this abandoned since there is something missing in the PR or it just can be re-based and merged? |
|
Considering the age and the fact that it requires quite a bit of rebasing: I am going to close the PR. I will add a note to gh-8581 that the PR is stale but could be a basis for bringing this up again. Thanks for opening the initial PR! |
Support for frequency weights and aweights in np.var. I've kept it coherent with
np.covand used the same consistency when ddof is not equal to zero or one.Fixes #5164