Skip to content

[MRG]: Fweight and aweight support for np.var - #5930

Closed
MechCoder wants to merge 2 commits into
numpy:mainfrom
MechCoder:weight_suport_var
Closed

[MRG]: Fweight and aweight support for np.var#5930
MechCoder wants to merge 2 commits into
numpy:mainfrom
MechCoder:weight_suport_var

Conversation

@MechCoder

Copy link
Copy Markdown
Contributor

Support for frequency weights and aweights in np.var. I've kept it coherent with np.cov and used the same consistency when ddof is not equal to zero or one.
Fixes #5164

@MechCoder

Copy link
Copy Markdown
Contributor Author

cc: @charris @ndawe @tpoole
I finally got some time to work on this. This might not be that important especially with the GSoC going on, but it might be good to have.

@MechCoder

Copy link
Copy Markdown
Contributor Author

bump?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo cobariance

@homu

homu commented Feb 8, 2016

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #4619) made this pull request unmergeable. Please resolve the merge conflicts.

@OmerJog

OmerJog commented May 5, 2019

Copy link
Copy Markdown

What is the status of this PR?

@rgommers

rgommers commented May 5, 2019

Copy link
Copy Markdown
Member

What is the status of this PR?

hmm, this never got followed up on.

The two types of weights are weird imho. Also in np.cov they're weird, explanation isn't clear and no example. It doesn't look too good. I'd be in favor of closing this, or otherwise just using normal weights.

@charris

charris commented May 5, 2019

Copy link
Copy Markdown
Member

@rgommers IIRC, there was quite a long discussion about the two weights.

@rgommers

rgommers commented May 5, 2019

Copy link
Copy Markdown
Member

maybe we can find it and document it properly then? it doesn't make too much sense right now imho .....

@charris

charris commented May 5, 2019

Copy link
Copy Markdown
Member

I can't find it with a quick search, but there was this, that tickles my memory.

@tpoole

tpoole commented May 5, 2019

Copy link
Copy Markdown
Contributor

The previous discussion can be found here: #4960

@OmerJog

OmerJog commented May 15, 2019

Copy link
Copy Markdown

So was this abandoned since there is something missing in the PR or it just can be re-based and merged?

Base automatically changed from master to main March 4, 2021 02:03
@seberg

seberg commented Sep 8, 2021

Copy link
Copy Markdown
Member

Considering the age and the fact that it requires quite a bit of rebasing: I am going to close the PR. I will add a note to gh-8581 that the PR is stale but could be a basis for bringing this up again.

Thanks for opening the initial PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: Weight support for np.var

8 participants