Conversation
Clarify that cdouble, unlike Python complex, does not accept keyword arguments. Document clongdouble as accepting one positional value, matching its implementation.
Aniketsy
reviewed
Sep 26, 2026
Comment on lines
+190
to
+191
| Unlike Python :class:`complex`, this constructor does not accept keyword | ||
| arguments. |
Contributor
There was a problem hiding this comment.
how about passing something like this to be just more informative. ( its upto you, you're verion is alredy fine)
Unlike Python :class:`complex`, ``real`` and ``imag`` must be passed positionally;
keyword arguments are not accepted.
Author
There was a problem hiding this comment.
Sure, I like that! I’ll update the PR
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
complex128/cdoubleare not correct #22322 (comment), clarify thatcdouble, unlike the Pythoncomplextype, does not accept keyword arguments.clongdoubleas accepting only one positional value, matching its implementation.(I also considered whether the
clongdoubleimplementation should be fixed instead, but I see from code here and associated PR that it may not be so simple)First time contributor introduction
Hello! I'm Greg, engineer at Bloomberg participating in the NumFOCUS Sustaining Open Source Series.
I've used numpy at work mainly for stats and timeseries calculations, relating to software systems telemetry.
AI Disclosure
I used OpenAI Codex used to help inspect and explain to me the relevant parts of the codebase, and to draft the documentation string edits and PR description.
I reviewed the changes and will participate in the PR manually.