Conversation
ngoldbaum
added
30 - API
63 - C API
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
I tried adding the new ByteStringDType dtypemeta to the C API and noticed that the hash didn't need to change. This sent me down a rabbit hole, producing this. With this PR the DType types are now included in the codegen (and thus the C API hash).
This nicely enables us to delete the two duplicate listings we currently need to maintain.
This should be purely a refactor. I marked this as an API change because it touches the
cversions.txthash.AI Disclosure
I iterated on this with an AI