Conversation
NaT is stored as the minimum int64 value, and casts to floating-point types used that value as is, giving -9.2e18. For float16 the value is out of range, so the cast gave -inf along with an overflow warning. The reverse cast already maps NaN to NaT. To match it, map NaT to NaN. For complex types, the real part is NaN and the imaginary part is 0. Casts to integer types and bool are unchanged. Integer types have no equivalent of NaN, and for int64 NaT stays the minimum value, so casting back to datetime gives NaT again. For bool, NaT is true, the same as NaN. Closes numpy#26177
Member
|
You ignored the PR template, so I'm going to assume that this PR has been made with agentic AI. This violates our AI policy; we prefer to talk to humans. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NaT is stored as the minimum int64 value, and casts to floating-point types used that value as is, giving -9.2e18. For float16 the value is out of range, so the cast gave -inf along with an overflow warning.
The reverse cast already maps NaN to NaT. To match it, map NaT to NaN. For complex types, the real part is NaN and the imaginary part is 0.
Casts to integer types and bool are unchanged. Integer types have no equivalent of NaN, and for int64 NaT stays the minimum value, so casting back to datetime gives NaT again. For bool, NaT is true, the same as NaN.
Closes #26177
PR summary
First time contributor introduction
AI Disclosure