Conversation
ngoldbaum
added
01 - Enhancement
component: numpy.strings
jorenham
self-requested a review
September 23, 2026 22:19
ngoldbaum
commented
Sep 23, 2026
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
ngoldbaum
force-pushed
the
bytestringdtype
branch
from
September 24, 2026 03:02
86ed230 to
ca755a7
Compare
This comment has been minimized.
This comment has been minimized.
ngoldbaum
commented
Sep 24, 2026
ngoldbaum
force-pushed
the
bytestringdtype
branch
from
September 24, 2026 22:53
ca755a7 to
8b36e1c
Compare
|
Diff from mypy_primer, showing the effect of this PR on type check results on a corpus of open source code: pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/series/test_series.py:2141: error: Expression is of type "Literal['b', 'i', 'u', 'f', 'c', 'm', 'M', 'O', 'S', 'U', 'V', 'T', 'R']", not "Literal['b', 'i', 'u', 'f', 'c', 'm', 'M', 'O', 'S', 'U', 'V', 'T']" [assert-type]
+ tests/series/test_series.py:2145: error: Expression is of type "Literal['b', 'i', 'u', 'f', 'c', 'm', 'M', 'O', 'S', 'U', 'V', 'T', 'R']", not "Literal['b', 'i', 'u', 'f', 'c', 'm', 'M', 'O', 'S', 'U', 'V', 'T']" [assert-type]
+ tests/series/test_series.py:2149: error: Expression is of type "Literal['b', 'i', 'u', 'f', 'c', 'm', 'M', 'O', 'S', 'U', 'V', 'T', 'R']", not "Literal['b', 'i', 'u', 'f', 'c', 'm', 'M', 'O', 'S', 'U', 'V', 'T']" [assert-type]
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27701
This PR is open as a draft and depends on the following open PRs:
AI Disclosure
I used AI models to work on and review this PR.