TYP: vectorize shape-typing - #32743
Merged
Merged
Conversation
jorenham
force-pushed
the
typing/vectorize/shape-typing
branch
from
September 21, 2026 20:33
f395073 to
76cf1bc
Compare
|
Diff from mypy_primer, showing the effect of this PR on type check results on a corpus of open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/io/stata.py:352: error: Incompatible types in assignment (expression has type "vectorize[signedinteger[_32Bit | _64Bit], Callable[[datetime], int]]", variable has type "vectorize[float64, Callable[[timedelta], float]]") [assignment]
|
Member
Author
|
The new mypy error for pandas (src) is a classic reassignment issue, where the result of different incompatible |
Member
|
Thanks Joren. |
Riaz1729
pushed a commit
to Riaz1729/numpy
that referenced
this pull request
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.vectorizenow has shape-typing support, and has been made aware of the arity and return type of the vectorized user function.It was a bit tricky to get this right because
vectorizecan both be used as a decorator and directly, and then there's also thesignaturewhich influences the output. After hammering at it to get it as simple as feasible, I'm pretty happy with how it turned out.Pair programmed with AI.