BUG: fix reference counting inconsistency - #32682
Merged
Merged
Conversation
This was referenced Sep 17, 2026
Member
|
Ci is good, so merging. Thanks @ngoldbaum |
eendebakpt
added a commit
to eendebakpt/numpy
that referenced
this pull request
Sep 21, 2026
Resolve a conflict with main: the previous merge picked up numpygh-32531 without its crash fix numpygh-32682. Co-Authored-By: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
I merged #32531 without merging with
mainfirst. In the intervening time there was a code change innpy_update_operand_if_pyscalarthat broke #32531. This removes an incref/decref pair that is no longer necessary post #32531.AI Disclosure
An AI found the site where the incref/decref needed to be deleted.