TYP: einsum shape-typing - #32588
Merged
Merged
TYP: einsum shape-typing#32588
einsum shape-typing#32588Conversation
Member
|
Thanks Joren. Interesting approach. |
|
cool! I'd never have thought of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At first I thought it would be impossible to shape-type
numpy.einsum, because it's not possible to statically parse the einsum string using Python's type system. However, I had AI do a survey to see if there are certain einsum strings that are used often. And as it turns out, we can cover ~41% of thenp.einsumcalls using a subset of the 112 most frequently used einsum strings. These are then grouped by output rank, and for each group an overload is added. So this way,einsumis shape-typed for ~41% of the use cases :).Researched and pair-programmed with AI.