Skip to content

TST: explain limited API tests - #32444

Merged
rgommers merged 2 commits into
numpy:mainfrom
kumaraditya303:explain-limited-api-tests
Aug 27, 2026
Merged

rgommers merged 2 commits into
numpy:mainfrom
kumaraditya303:explain-limited-api-tests

Conversation

@kumaraditya303

Copy link
Copy Markdown
Contributor

PR summary

This PR adds comments to better explain how the limited API test works. See #32407 (comment)

AI Disclosure

The comments were written with help of AI and verified by me.

@rgommers rgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kumaraditya303, this would have helped a lot. The one thing I'd add, which is why the test didn't make sense to me at first, is this:

# Normally a single Python package uses a single Python and a single NumPy version
# as the target (i.e., lowest-supported) version, so this test isn't realistic in that respect.
# However, it *is* realistic for cross-package issues between extension modules. This can
# happen in practice, e.g. when Cython extensions load types/objects from sys.modules` 
# instead of from the local copy embedded in each extension (cython#7914).

@kumaraditya303

Copy link
Copy Markdown
Contributor Author

The one thing I'd add, which is why the test didn't make sense to me at first, is this:

Added.

@rgommers rgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks again!

@rgommers
rgommers merged commit 8d8c637 into numpy:main Aug 27, 2026
89 of 91 checks passed
@rgommers rgommers added this to the 2.6.0 Release milestone Aug 27, 2026
@kumaraditya303
kumaraditya303 deleted the explain-limited-api-tests branch August 27, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants