TYP: clip improved shape-typing and dtype propagation - #32204
Merged
Merged
Conversation
Member
|
Thanks Joren. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.clipnow also propagates the input shape-type and input dtype in more common cases.Note however that there is still room for (shape-typing) improvement, because the broadcasting behavior of
a_minanda_maxis currently not taken into account (doing so would result in a combinatorial explosion of overloads, so that's why).Passing these as scalars is by far the most common usecase though, so I don't think that all of these additional overloads are worth it, and I'll just mark this as "done" in https://gist.github.com/jorenham/36c78602a7ca866ddb2a917de48ccdd0.
Fully written by me, audited as kinda-high-value shape-typing improvement by AI (see https://gist.github.com/jorenham/36c78602a7ca866ddb2a917de48ccdd0).