ENH: Added display modes for show_runtime - #26255
Merged
Merged
Conversation
ganesh-k13
added a commit
to ganesh-k13/numpy
that referenced
this pull request
Apr 10, 2024
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
April 10, 2024 13:59
6e3b392 to
f1d6df9
Compare
ganesh-k13
added a commit
to ganesh-k13/numpy
that referenced
this pull request
Apr 10, 2024
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
April 10, 2024 14:02
f1d6df9 to
d55c7ce
Compare
ganesh-k13
added a commit
to ganesh-k13/numpy
that referenced
this pull request
Apr 10, 2024
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
April 10, 2024 14:06
d55c7ce to
52f335a
Compare
ganesh-k13
commented
Apr 10, 2024
Member
|
@ganesh-k13 will you be continuing with this? |
Member
Author
|
@mattip , I'll pick it up this weekend. Got a bit busy lately. |
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
July 5, 2024 10:53
52f335a to
525373d
Compare
ganesh-k13
added a commit
to ganesh-k13/numpy
that referenced
this pull request
Jul 5, 2024
ganesh-k13
marked this pull request as ready for review
July 5, 2024 11:15
Member
|
@ganesh-k13 it would be nice to push this over the finish line. There are merge conflicts. |
Member
Author
|
Thanks for looking into this. I'll get the merge conflicts resolved this week. |
ganesh-k13
added a commit
to ganesh-k13/numpy
that referenced
this pull request
Jan 29, 2026
ganesh-k13
force-pushed
the
show_runtime_modes
branch
2 times, most recently
from
January 29, 2026 05:40
180c3ea to
342e368
Compare
Member
|
|
Member
Author
|
Debugging why But it's quite hard to narrow down what is actually failing. Will fix this today. [edit] Made some tweaks and got the failing fns: {'category': 'function', 'name': 'numpy.show_runtime', 'referenceCount': 1, 'isExported': True, 'isTypeKnown': False, 'isTypeAmbiguous': False, 'diagnostics': [{'file': '/Users/gakathir/Documents/os/numpy/build-install/usr/lib/python3.13/site-packages/numpy/lib/_utils_impl.pyi', 'severity': 'warning', 'message': 'No docstring found for function "numpy.show_runtime"', 'range': {'start': {'line': 586, 'character': 4}, 'end': {'line': 586, 'character': 16}}}, {'file': '/Users/gakathir/Documents/os/numpy/build-install/usr/lib/python3.13/site-packages/numpy/lib/_utils_impl.pyi', 'severity': 'error', 'message': 'Return type is partially unknown\n\xa0\xa0Return type is "dict[Unknown, Unknown] | None"\n\xa0\xa0\xa0\xa0Type argument 1 for class "dict" has unknown type\n\xa0\xa0\xa0\xa0Type argument 2 for class "dict" has unknown type', 'range': {'start': {'line': 586, 'character': 4}, 'end': {'line': 586, 'character': 16}}}]}
{'category': 'function', 'name': 'numpy.matlib.show_runtime', 'referenceCount': 1, 'isExported': True, 'isTypeKnown': False, 'isTypeAmbiguous': False, 'diagnostics': [{'file': '/Users/gakathir/Documents/os/numpy/build-install/usr/lib/python3.13/site-packages/numpy/__init__.pyi', 'severity': 'warning', 'message': 'No docstring found for function "numpy.matlib.show_runtime"', 'range': {'start': {'line': 416, 'character': 4}, 'end': {'line': 416, 'character': 16}}}, {'file': '/Users/gakathir/Documents/os/numpy/build-install/usr/lib/python3.13/site-packages/numpy/__init__.pyi', 'severity': 'error', 'message': 'Return type is partially unknown\n\xa0\xa0Return type is "dict[Unknown, Unknown] | None"\n\xa0\xa0\xa0\xa0Type argument 1 for class "dict" has unknown type\n\xa0\xa0\xa0\xa0Type argument 2 for class "dict" has unknown type', 'range': {'start': {'line': 416, 'character': 4}, 'end': {'line': 416, 'character': 16}}}]} |
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
January 30, 2026 04:57
3dae15b to
5a039dd
Compare
Member
Author
jorenham
reviewed
Jan 30, 2026
ganesh-k13
added a commit
to ganesh-k13/numpy
that referenced
this pull request
Sep 7, 2026
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
September 7, 2026 05:28
88c1cf6 to
9081f26
Compare
jorenham
reviewed
Sep 7, 2026
ganesh-k13
added a commit
to ganesh-k13/numpy
that referenced
this pull request
Sep 8, 2026
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
September 8, 2026 02:51
9081f26 to
3d124dc
Compare
jorenham
reviewed
Sep 15, 2026
Additionally created a util file for common functions between `show_config` and `show_runtime`
Co-authored-by: Joren Hammudoglu <[email protected]>
Co-authored-by: Ralf Gommers <[email protected]>
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
September 21, 2026 18:55
3d124dc to
d6cdd03
Compare
jorenham
self-requested a review
September 21, 2026 19:04
jorenham
approved these changes
Sep 21, 2026
jorenham
left a comment
Member
There was a problem hiding this comment.
The typing changes look right 👌
Member
|
Thanks @ganesh-k13 |
Riaz1729
pushed a commit
to Riaz1729/numpy
that referenced
this pull request
Sep 23, 2026
Co-authored-by: Joren Hammudoglu <[email protected]> Co-authored-by: Ralf Gommers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
show_runtimeAllowed modes are same as
show_config`dicts` mode
`stdout` mode (default)
ToDo
Notes
resolves: https://mail.python.org/archives/list/[email protected]/thread/NF7ET6O5ELCLXGEIN7P2AUO5S4MESMSK/