Skip to content

MAINT, Benchmark: print the supported CPU features during the run of performance tests - #17737

Merged
charris merged 2 commits into
numpy:mainfrom
seiko2plus:benchmark_simd_info
Apr 23, 2021
Merged

MAINT, Benchmark: print the supported CPU features during the run of performance tests#17737
charris merged 2 commits into
numpy:mainfrom
seiko2plus:benchmark_simd_info

Conversation

@seiko2plus

@seiko2plus seiko2plus commented Nov 9, 2020

Copy link
Copy Markdown
Member

print the supported CPU features during the run of performance tests

releated to #17736, #17716

@seiko2plus seiko2plus mentioned this pull request Nov 9, 2020
Merged
@mattip

mattip commented Nov 9, 2020

Copy link
Copy Markdown
Member

The output of runtest.py, and now asv is getting quite verbose with this extra information. We need to find a better way to report it. Is there a way to add it to the json output of asv? Also, the function is not specific to running benchmarks so it would be nice to add it into the codebase in a more general way.

@seiko2plus

seiko2plus commented Nov 10, 2020

Copy link
Copy Markdown
Member Author

The output of runtest.py, and now asv is getting quite verbose with this extra information

I workaround it by implmenting ppid based lock.

We need to find a better way to report it. Is there a way to add it to the json output of asv?

unfortunately, I couldn't find any reference for such a case like this.

Also, the function is not specific to running benchmarks so it would be nice to add it into the codebase in a more general way.

I move it to lib/utils.

seiko2plus
seiko2plus commented Nov 10, 2020
View reviewed changes
Comment thread benchmarks/benchmarks/__init__.py Outdated
seiko2plus
seiko2plus commented Nov 10, 2020
View reviewed changes
Comment thread benchmarks/benchmarks/__init__.py Outdated
@mattip

mattip commented Nov 10, 2020

Copy link
Copy Markdown
Member

xref airspeed-velocity/asv#791 for adding metadata to the benchmark results.

@mattip mattip mentioned this pull request Nov 12, 2020
Closed
Base automatically changed from master to main March 4, 2021 02:05
@charris

charris commented Apr 22, 2021

Copy link
Copy Markdown
Member

close/reopen

@charris charris closed this Apr 22, 2021
@charris charris reopened this Apr 22, 2021
@charris

charris commented Apr 22, 2021

Copy link
Copy Markdown
Member

@mattip Ping.

@charris

charris commented Apr 22, 2021

Copy link
Copy Markdown
Member

@seiko2plus Needs long line fixes.

@seiko2plus
seiko2plus force-pushed the benchmark_simd_info branch from 4091f8e to 61a495e Compare April 22, 2021 21:24
@seiko2plus
seiko2plus force-pushed the benchmark_simd_info branch from 61a495e to 523d70f Compare April 22, 2021 21:41
@seiko2plus
seiko2plus force-pushed the benchmark_simd_info branch from 523d70f to 472b152 Compare April 22, 2021 21:58
@charris
charris merged commit da6952f into numpy:main Apr 23, 2021
@charris

charris commented Apr 23, 2021

Copy link
Copy Markdown
Member

Thanks Sayed.

@rgommers rgommers added the component: SIMD Issues in SIMD (fast instruction sets) code or machinery label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

03 - Maintenance component: SIMD Issues in SIMD (fast instruction sets) code or machinery

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

4 participants

@seiko2plus @mattip @charris @rgommers