Repository navigation
MAINT: Make void scalar to array creation copy when dtype is given - #16820
Merged
Merged
Conversation
This retains the old behaviour, where the non-copy semtantics was only used when no dtype is passed in at all.
Member
|
close/reopen |
Member
|
LGTM. Shouldn't the title be "Make void scalar to array creation copy when no dtype is given" |
Member
Author
|
The behaviour is to retain the view if there is only a scalar passed in, but do the copy when scalar+scalar.dtype is passed in. |
Member
|
Thanks @seberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This retains the old behaviour, where the non-copy semtantics
was only used when no dtype is passed in at all.
this is a small followup to gh-16200 simply because right now it slightly changed behaviour as it was.