Skip to content

BUG: fix decode error when building and get rid of warn - #16789

Merged
mattip merged 1 commit into
numpy:masterfrom
Qiyu8:fix-decode
Jul 9, 2020
Merged

mattip merged 1 commit into
numpy:masterfrom
Qiyu8:fix-decode

Conversation

@Qiyu8

@Qiyu8 Qiyu8 commented Jul 9, 2020

Copy link
Copy Markdown
Member

Fix #16668
The build may fail to decode in non utf-8 environment , So force the output to be text(no need to decode then) and get rid of the msvc warning.

@mattip
mattip merged commit 90177d6 into numpy:master Jul 9, 2020
@mattip

mattip commented Jul 9, 2020

Copy link
Copy Markdown
Member

Thanks @Qiyu8.

@charris charris added 00 - Bug 09 - Backport-Candidate PRs tagged should be backported component: numpy.distutils and removed 09 - Backport-Candidate PRs tagged should be backported labels Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Failure on Windows, Python 3.6 GCC Compilers: UnicodeDecodeError.

3 participants