Skip to content

DOC: Document that scale==0 is now allowed in many distributions. - #12964

Merged
charris merged 2 commits into
numpy:masterfrom
mattip:doc-fixes
Feb 19, 2019
Merged

charris merged 2 commits into
numpy:masterfrom
mattip:doc-fixes

Conversation

@mattip

@mattip mattip commented Feb 13, 2019

Copy link
Copy Markdown
Member

[ci skip]
Fixes #11125. Related to #5822.
We allowed 0 for the scale factor long ago, but never reflected it in the documentation.

@charris

charris commented Feb 14, 2019

Copy link
Copy Markdown
Member

I remember some of these. Did you check that zero is accepted/works in all of these? Otherwise looks good to me.

@charris

charris commented Feb 15, 2019

Copy link
Copy Markdown
Member

Need to add lognormal (sigma), and wald is in conflict with the code.

@charris charris changed the title DOC: reflect changes from #5822 (from May 2015) in the docs DOC: Document that scale==0 is now allowed in many distributions. Feb 16, 2019
Comment thread numpy/random/mtrand/mtrand.pyx Outdated
Comment thread numpy/random/mtrand/mtrand.pyx Outdated
@charris

charris commented Feb 18, 2019

Copy link
Copy Markdown
Member

@mattip Needs rebase. If you make the fixes we can put this in.

@mattip mattip left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added lognormal(sigma)

Comment thread numpy/random/mtrand/mtrand.pyx Outdated
@charris
charris merged commit 95db8c2 into numpy:master Feb 19, 2019
@charris

charris commented Feb 19, 2019

Copy link
Copy Markdown
Member

Thanks Matti.

@mattip
mattip deleted the doc-fixes branch May 20, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants