Skip to content

Fixed documentation typo in CLA Classifier#504

Merged
cogmission merged 2 commits into
numenta:masterfrom
JonnoFTW:master
Oct 29, 2016
Merged

Fixed documentation typo in CLA Classifier#504
cogmission merged 2 commits into
numenta:masterfrom
JonnoFTW:master

Conversation

@JonnoFTW
Copy link
Copy Markdown
Contributor

@JonnoFTW JonnoFTW commented Oct 26, 2016

Fixes #505

I fixed a typo about the return type and the example in the comment using mixed decimal point styles.

Swapped from mixed European commas to sane commas in decimal number documentation.
@cogmission
Copy link
Copy Markdown
Collaborator

cogmission commented Oct 26, 2016

@JonnoFTW
Thanks dude!

  1. You need to sign the CL (contributor's license) and then Matt will "approve" it and that first error will go away ;-)
  2. You need to open up an "issue" and then in the comment above within this PR, you should put ```Fixes #" --> take a look at this as an example (where it says "Fixes") at the top.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 83.077% when pulling 6fcf544 on JonnoFTW:master into fce1837 on numenta:master.

@cogmission
Copy link
Copy Markdown
Collaborator

@rhyolight Please review @JonnoFTW 's CL

@cogmission cogmission closed this Oct 27, 2016
@cogmission cogmission reopened this Oct 27, 2016
@cogmission
Copy link
Copy Markdown
Collaborator

@JonnoFTW Have you signed the Contributor's License yet?

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 83.077% when pulling 6fcf544 on JonnoFTW:master into fce1837 on numenta:master.

@JonnoFTW
Copy link
Copy Markdown
Contributor Author

@cogmission yes I have. I got confirmation that it was received this morning.

@rhyolight
Copy link
Copy Markdown
Member

@JonnoFTW @cogmission It's all good. There is something wrong with the validator. Good to merge. 👍

@cogmission
Copy link
Copy Markdown
Collaborator

@rhyolight Thanks buddy!

@cogmission cogmission merged commit 8724afa into numenta:master Oct 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation for CLA Classifier has typos regarding return types and decimal places

4 participants