Added fix for potential radius#484
Merged
Merged
Conversation
Collaborator
Author
|
@rhyolight Please accept. This is the potentialRadius fix for HTM.Java |
rhyolight
requested changes
Sep 28, 2016
Member
rhyolight
left a comment
rhyolight
left a comment
There was a problem hiding this comment.
Only comment is to remove all but two warnings. They should only exist where the value could be set.
| * | ||
| * <b>WARNING:</b> potentialRadius **must** be set to | ||
| * the inputWidth if using "globalInhibition" and if not | ||
| * using the Network API (which sets this automatically) |
Member
There was a problem hiding this comment.
No need for this warning comment on a getter.
Collaborator
Author
There was a problem hiding this comment.
Ok. I removed this one on the "getter"
| * the inputWidth if using "globalInhibition" and if not | ||
| * using the Network API (which sets this automatically) | ||
| */ | ||
| defaultSpatialParams.put(KEY.POTENTIAL_RADIUS, -1); |
Member
There was a problem hiding this comment.
I think this warning is in too many places. It makes sense to put it in the setter or constructor (where the value can be set), but not everywhere.
Collaborator
Author
There was a problem hiding this comment.
I removed this one, but I added it (where it should have been), on the key itself (where it will be looked up).
rhyolight
approved these changes
Sep 28, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #483