Repository navigation
Break connection if Wait gets timeout with SSL and netstandard2.0 - #4415
Merged
Merged
Conversation
roji
commented
Apr 15, 2022
Member
Author
There was a problem hiding this comment.
Note a small fix here: before, if a cancellation was requested, we just bubbled up the exception, unlike non-Wait where we would throw a new OperationCanceledException (presumably to get the right cancellation token). This PR aligns Wait with that.
vonzshik
approved these changes
Apr 15, 2022
Because in .NET Framework, SslStream is dead after any IOException. Fixes npgsql#4342
Member
Author
|
Backported to 6.0.4 via 65a7ec7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because in .NET Framework, SslStream is dead after any IOException.
Fixes #4342