[CCL] fix condition issue in ccl.py - #6443
Merged
Merged
Conversation
loadams
approved these changes
Aug 26, 2024
loadams
approved these changes
Aug 27, 2024
loadams
enabled auto-merge
August 27, 2024 22:06
loadams
disabled auto-merge
August 27, 2024 22:07
loadams
added a commit
that referenced
this pull request
Aug 27, 2024
Collaborator
|
I wanted to check this on XPU and HPU, XPU: https://github.com/microsoft/DeepSpeed/actions/runs/10586606972/job/29335722768 |
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Mar 20, 2025
previous condition check is not right, it would cause this condition always be True. --------- Co-authored-by: Logan Adams <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous condition check is not right, it would cause this condition always be True.