feat(ui): implement deep linking in CodeTabs via URL hash by moshams272 · Pull Request #9159 · nodejs/nodejs.org

moshams272 · 2026-09-13T17:24:49Z

Description

Implement deep linking in CodeTabs component by using the active tab state via the URL hash.

In Details

Add optional groupId prop to generate unique anchor IDs across multiple CodeTabs instances on the same page in format: tab-{groupId}-{language}-{index}, falling back to React's useId() when groupId is not provided.
Read the URL hash on mount via a lazy initializer in useState() to set the correct initial tab without a double render.
Update the URL silently on tab click using history.replaceState to avoid polluting the browser history

Validation

After building, I checked the tabs by clicking on them, and then the URL hash changed.

Related Issues

Fixes #9140

Check List

I have read the Contributing Guidelines and made commit messages that follow the guideline.
I have run pnpm format to ensure the code follows the style guide.
I have run pnpm test to check if all tests are passing.
I have run pnpm build to check if the website builds without errors.
I've covered new added functionality with unit tests if necessary.

vercel · 2026-09-13T17:24:53Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
nodejs-org	Ready	Preview	Sep 15, 2026 9:12pm UTC

ovflowd

We want to avoid having the CodeTabs being a client-component in all cases. We could use a wrapper that uses use client specifically for when these groupIds or whatnot are passed, ands we can do the logic of what gets used on shiki I guess?

That said per the repo guidelines it is an absolute no-go using winodw APIs from within components, not to mention adding so many event listeners (1 per CodeTab) is going to be an absolute nightmare for the browser.

AugustinMauroy · 2026-09-13T20:41:20Z

I dunno how to reproduce what I have done but it's may happened

avivkeller

LGTM minus Claudio's concerns

moshams272 · 2026-09-14T08:22:14Z

We want to avoid having the CodeTabs being a client-component in all cases. We could use a wrapper that uses use client specifically for when these groupIds or whatnot are passed, ands we can do the logic of what gets used on shiki I guess?

That said per the repo guidelines it is an absolute no-go using winodw APIs from within components, not to mention adding so many event listeners (1 per CodeTab) is going to be an absolute nightmare for the browser.

Got it, I saw the use client used in BaseCodeBox first. After your comment, I find the pattern you mean used in AvatarGroup.

I think Augustin's bug happened because of the React Hydration Error in the useState.

ovflowd · 2026-09-14T12:02:42Z

Got it, I saw the use client used in BaseCodeBox first. After your comment, I find the pattern you mean used in AvatarGroup.

We might need to revisit why BaseCodeBox uses "use client" but still we should thrive for reducing client components as much as possible :)

moshams272 · 2026-09-14T12:06:08Z

We might need to revisit why BaseCodeBox uses "use client" but still we should thrive for reducing client components as much as possible :)

I reached for a fair solution. We use useMediaQuery.ts as a custom hook and access the window through it. So, could I do the same?! Or we should revisit it too ;)

It's an initial thinking for now.

ovflowd · 2026-09-14T12:44:31Z

I reached for a fair solution. We use useMediaQuery.ts as a custom hook and access the window through it. So, could I do the same?! Or we should revisit it too ;)

In terms of should window APIs be behind safe Hooks, yes. But in terms of, should we have god knows how many Event Listeners because they're tied to one CodeBox? No.

You might want to think of a React Context Provider, with one hook that keeps an eye on Hash changes. Or you might defer it to a HoC, so that on the apps, such as Next.js and doc-kit we defer the implementation of this, for example, Next.js has a Router/Navigation API, you could inject results on the CodeBox...

I guess it's more of a thinking of "who should be responsible for listening to this" you could argue it should be the Component itself, because he's the one interested on this, that said, it's only interested on the scenarios where it should even care abou that. IMO, the Component should subscribe to the changes aka ask to the parent component or context provider "has the hash changed?" ... yet that the responsibility of actually setting up the Event Listener shouldn't be part of the Component's responsibility.... As "Window" or even a Hook that "listens to Window" is something unbeknown to the Component. The Component's "world" should always be anything that is inside said Component. That's a very common mistake some React Components do on, for example, Modals. Where they let the Modal itself be the one observing if anyone clicked outside the Modal, whereas that should never be the Modal's responsibility.

So think a bit of how to approach this, both in a way that is properly designed and that can be reused (ie: if this is a prop/callback to the Component, you defer the implementation details (be it window APIs, be it Next.js APIs...) to the consumer) and how to make it reliable and performant.

I hope my explanation helps!

moshams272 · 2026-09-15T23:07:36Z

Screencast.from.2026-09-16.02-04-21.webm

I hope I did it right :)

AugustinMauroy · 2026-09-16T07:34:13Z

that seem cool but on safari and vercel preview I cannot having them working

moshams272 · 2026-09-16T09:13:12Z

that seem cool but on safari and vercel preview I cannot having them working

Yeah, I'll summarize what I did:

In our app:
- Created a hash hook. This hook works on both sides (server & browser). On server or hydration, it'll do nothing that makes the CodeTabs trigger the default tab, so they will not dismatch. On browser, it will take the hash, and I just add one event listener on window, and created a set to rerender the components manually as the React new hook useSyncExternalStore gives me a callback to trigger.
- Created a hash provider to use this hook and pass this result to ui-components.
In ui-components:
- Created a hash context, why not create it in the app? If we did that, we let our library call the context from the app and we need to make it stanalone library. So who will use this feature should give us the hash through our context.
- Added an optional groupId feature in CodeTabs. This component works on the server side. However, If you need to use the groupId, the heavy work will still be on the server, and then pass the data to a client component to manage the state and use the context and hash here for sure.

So we haven't been added groupId to any MDX files yet, that means there is no hash needed and the component will fallback to the server component, that is the same for the old one we use now before this PR.

To actually see it works, a <CodeTabs> component needs the new groupId prop. I can push a temporary test snippet to about/index.mdx -that's what I did locally, BTW- so you can test the Safari & Vercel preview. We can simply revert it right before merging.

ovflowd · 2026-09-30T11:58:47Z

+import { useSyncExternalStore } from 'react';
+
+const listeners = new Set<() => void>();
+let isListening = false;


nit: can we not use a top level let? Use React APIs such a memo() or cache()

ovflowd · 2026-09-30T11:59:10Z

+
+import { useSyncExternalStore } from 'react';
+
+const listeners = new Set<() => void>();


Same here, listeners itself should be a top-level cache, not a top level const

ovflowd · 2026-09-30T12:02:38Z

+  };
+};
+
+const getSnapshot = () =>


We shouldn't use window APIs on ui-components -- use context providers that UI Components use (I guess there's a global one? Like client-context or server-context?) -- otherwise probably have that being passed? I'm unsure if UI components should have environment specific wars. Maybe instead of window.location use at least globalThis or self or have Location be passed from downstream?

Ah you already have a Provider, have the Provider have a prop of location={Location}

(and ensure doc-kit and Next.js can pass that with their Navigation/Router APIs natively, or instead of Location they pass History, idk

ovflowd · 2026-09-30T12:03:04Z

+
+import type { FC, PropsWithChildren } from 'react';
+
+export const HashProvider: FC<PropsWithChildren> = ({ children }) => {


nit: Have Location be passed to the HashProvider ;)

ovflowd · 2026-09-30T12:05:09Z

-  }, [rawLanguages, rawDisplayNames]);
+  }, [rawLanguages, rawDisplayNames, groupId]);
+
+  const Component = groupId ? CodeTabsWithHash : CodeTabs;


This shouldn't be decided here IMO, but on our rehype shiki plugin. The name of the component to be used (CodeTabs) is passed there, so we can do the right pass directly from there, which reduces verbosity. This also removes the need of regular CodeTabs having an optional Group ID param

ovflowd · 2026-09-30T12:05:19Z

      return {
        key: `${language}-${index}`,
        label,
+        id:


ovflowd · 2026-09-30T12:06:15Z

+  const [activeTab, setActiveTab] = useState(defaultValue);
+  const [prevHash, setPrevHash] = useState(hash);
+
+  if (hash !== prevHash) {


This shouldn't be on the root of a Component, that's a big no-go. Use an Effect.

feat(ui): implement deep linking in CodeTabs via URL hash

55de7aa

moshams272 requested a review from a team as a code owner September 13, 2026 17:24

vercel Bot deployed to Preview September 13, 2026 17:26 View deployment

ovflowd requested changes Sep 13, 2026

View reviewed changes

avivkeller approved these changes Sep 13, 2026

View reviewed changes

moshams272 added 4 commits September 15, 2026 18:52

feat(site,ui): add HashContext and HashProvider for global URL state

9b3d739

refactor(ui): isolate window hash logic from CodeTabs

6707e8c

chore: improve code documentation for useHash hook

15d5e2a

feat(ui): use native DOM id for CodeTabs scrolling

aaba3ab

vercel Bot deployed to Preview September 15, 2026 21:12 View deployment

moshams272 requested a review from ovflowd September 25, 2026 15:22

moshams272 mentioned this pull request Sep 30, 2026

feat(ui): group overloaded functions into tabs nodejs/doc-kit#1047

Open

4 tasks done

ovflowd reviewed Sep 30, 2026

View reviewed changes


		import { useSyncExternalStore } from 'react';

		const listeners = new Set<() => void>();


		import type { FC, PropsWithChildren } from 'react';

		export const HashProvider: FC<PropsWithChildren> = ({ children }) => {

Conversation

moshams272 commented Sep 13, 2026

Description

In Details

Validation

Related Issues

Check List

Uh oh!

vercel Bot commented Sep 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy commented Sep 13, 2026

Uh oh!

avivkeller left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moshams272 commented Sep 14, 2026

Uh oh!

ovflowd commented Sep 14, 2026

Uh oh!

moshams272 commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovflowd commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moshams272 commented Sep 15, 2026

Uh oh!

AugustinMauroy commented Sep 16, 2026

Uh oh!

moshams272 commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel Bot commented Sep 13, 2026 •

edited

Loading

avivkeller left a comment •

edited

Loading

moshams272 commented Sep 14, 2026 •

edited

Loading

ovflowd commented Sep 14, 2026 •

edited

Loading

moshams272 commented Sep 16, 2026 •

edited

Loading