This repository was archived by the owner on Apr 26, 2024. It is now read-only.
feat(codeblock): added multi-language code block functionality for API docs#3261
Merged
feat(codeblock): added multi-language code block functionality for API docs#3261
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3261 +/- ##
==========================================
- Coverage 66.02% 64.73% -1.29%
==========================================
Files 118 145 +27
Lines 1351 1764 +413
Branches 342 411 +69
==========================================
+ Hits 892 1142 +250
- Misses 422 573 +151
- Partials 37 49 +12 see 197 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Member
Author
|
@shanpriyan could I get a review? :) |
github-actions
bot
removed
the
create-preview
|
Please find a preview at: https://staging.nodejs.dev/3261/ |
Member
Author
|
@shanpriyan this PR is not something you can see in a preview. You will need to checkout locally and run the |
shanpriyan
reviewed
Mar 10, 2023
Member
Author
|
HERE WE GO YALL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the support and grouping of API Docs Code Blocks into a single Code Block. This uses then our
Codeboxcomponent (#3249) to support switching between languages.The PR also attempts to solve a pertinent issue regarding the docs generation process (which is an unrelated change, but small enough to be part of this PR. It can be decoupled from this PR if the reviewers deem it needed).
Related Issues
Closes #2844