Use old-style functions and use safe-buffer#122
Closed
gabrielschulhof wants to merge 1 commit into
Closed
Conversation
gabrielschulhof
force-pushed
the
120-safe-buffer
branch
from
August 25, 2017 10:48
07920b6 to
8a71556
Compare
gabrielschulhof
pushed a commit
to gabrielschulhof/node-addon-api
that referenced
this pull request
Aug 25, 2017
* err => {} notation doesn't work on Node 4.
* Run test that uses Buffer.alloc only if ("alloc" in Buffer).
Fixes: nodejs#120
PR-URL: nodejs#122
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer
Fixes: nodejs#120
PR-URL: nodejs#122
gabrielschulhof
force-pushed
the
120-safe-buffer
branch
from
August 25, 2017 10:54
8a71556 to
252e7fe
Compare
gabrielschulhof
changed the title
mhdawson
pushed a commit
that referenced
this pull request
Aug 25, 2017
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer
PR-URL: #122
Fixes: #120
Reviewed-By: Michael Dawson <[email protected]>
Member
|
Landed as 790de9f |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer
PR-URL: nodejs/node-addon-api#122
Fixes: nodejs/node-addon-api#120
Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer
PR-URL: nodejs/node-addon-api#122
Fixes: nodejs/node-addon-api#120
Reviewed-By: Michael Dawson <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer
PR-URL: nodejs/node-addon-api#122
Fixes: nodejs/node-addon-api#120
Reviewed-By: Michael Dawson <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer
PR-URL: nodejs/node-addon-api#122
Fixes: nodejs/node-addon-api#120
Reviewed-By: Michael Dawson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #120