test: mark some tests flaky for now on riscv64 - #65781
Open
sxa wants to merge 1 commit into
Open
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Collaborator
mcollina
approved these changes
Sep 4, 2026
Member
Author
|
Seems to work - https://ci.nodejs.org/job/node-test-commit-rvlinux/nodes=riscv64/9/ shows yellow warning status instead of red with this change. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65781 +/- ##
==========================================
+ Coverage 89.96% 90.07% +0.10%
==========================================
Files 757 769 +12
Lines 258129 261396 +3267
Branches 48946 49636 +690
==========================================
+ Hits 232219 235445 +3226
+ Misses 16982 16968 -14
- Partials 8928 8983 +55 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While RISC-V is an experimental platform I have been testing it in a CI job. The tests in here are currently causing problems, although I have had them all pass at one point from the command line. The reasons for them failing vary, but for now since I know they can pass I'd like to mark them flaky to stop the CI job going red while we try and improve things on this platform. Note that this is NOT currently included as a subjob of the main node-test-commit job so has no impact on Node.js collaborators. I want to be able to use that job to quickly identify regressions going forward and for that I need to be able to have a clean baseline. If anyone fundamentally objects to this approach on this experimental platform let me know.
Failures can be seen in https://ci.nodejs.org/job/node-test-commit-rvlinux/6/testReport
I'll tag @codebytere for awareness just because one of the tests here being the reproducible snapshot one and there probably aren't many people who know that area in enough detail to have any opinion on it :-) I doubt it's anything really obvious so not critical as I'm trying to skip it here but the error is in the log above if anyone wants to look at it.
Tracking issue for problems on RISC-V is at nodejs/build#4099
Cc @nodejs/platform-riscv64