quic: apply multiple fixes to flow control signaling - #65309
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65309 +/- ##
==========================================
- Coverage 90.05% 90.05% -0.01%
==========================================
Files 751 751
Lines 254868 254906 +38
Branches 48107 48115 +8
==========================================
+ Hits 229531 229543 +12
- Misses 16511 16528 +17
- Partials 8826 8835 +9
🚀 New features to boost your workflow:
|
Collaborator
Contributor
|
Great addition to find more stalls in the pipeline. |
Collaborator
Member
Author
|
@pimterry @Ethan-Arrowood @nodejs/quic ... really need to get this landed before we muck around with more of the quic impl |
jasnell
force-pushed
the
jasnell/quic-flow-control-fixes
branch
2 times, most recently
from
August 25, 2026 02:51
242734c to
d889ee8
Compare
pimterry
approved these changes
Aug 26, 2026
Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode/Opus
jasnell
force-pushed
the
jasnell/quic-flow-control-fixes
branch
from
August 27, 2026 04:10
d889ee8 to
3bdafb6
Compare
Collaborator
jasnell
added
the
author ready
pimterry
approved these changes
Aug 27, 2026
Collaborator
Ethan-Arrowood
approved these changes
Aug 27, 2026
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
Contributor
There was a problem hiding this comment.
All LGTM. Tests coverage is great. Had my agent help me review the rest of the implementation and it didn't find anything either. One minor nit that can honestly be ignored unless you're doing another commit anyways.
jasnell
added a commit
that referenced
this pull request
Aug 27, 2026
Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode/Opus PR-URL: #65309 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
Member
Author
|
Landed in 05a8e91 |
aduh95
pushed a commit
that referenced
this pull request
Aug 29, 2026
Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode/Opus PR-URL: #65309 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Sep 3, 2026
Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode/Opus PR-URL: #65309 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing up the QUIC flow control signaling and closed stream handling, expand tests.
Update the flow control handling after the iter streams byte-budget based flow control updates.
@nodejs/quic @pimterry @martenrichter