Skip to content

doc: document net Socket server property - #64364

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
efekrskl:doc/socket-server-doc
Jul 13, 2026
Merged

doc: document net Socket server property#64364
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
efekrskl:doc/socket-server-doc

Conversation

@efekrskl

@efekrskl efekrskl commented Jul 8, 2026

Copy link
Copy Markdown
Member

Closes #47148, based on the change proposed in #63458.

Original patch and investigation by @Herrtian

@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. net Issues and PRs related to the net subsystem. labels Jul 8, 2026
@efekrskl

efekrskl commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

@Herrtian I revived your patch from #63458 so it wouldn't get lost, and credited you in the PR body. If you want, I can also add you as a co-author later, but I wanted to ask for your explicit approval for that first because we need to sign it off.

pimterry
pimterry approved these changes Jul 8, 2026
View reviewed changes

@pimterry pimterry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure what went wrong with the original PR process but thanks for picking this up @efekrskl!

@Herrtian

Herrtian commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@efekrskl Thanks for reviewing, I would appreciate if you add me as a co-author.

@efekrskl @Herrtian
doc: document net Socket server property
2f9130e 
Based on nodejs#63458.

Co-authored-by: Herrtian <[email protected]>
Signed-off-by: Efe Karasakal <[email protected]>
Signed-off-by: Herrtian <[email protected]>
@efekrskl
efekrskl force-pushed the doc/socket-server-doc branch from 1a91367 to 2f9130e Compare July 8, 2026 21:16
@efekrskl

efekrskl commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

@efekrskl Thanks for reviewing, I would appreciate if you add me as a co-author.

I added you as co-author, thanks a lot for your contribution!

@pimterry pimterry added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 13, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 13, 2026
@nodejs-github-bot
nodejs-github-bot merged commit e84b517 into nodejs:main Jul 13, 2026
19 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Landed in e84b517

aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@efekrskl @Herrtian @aduh95
doc: document net Socket server property
4aa93b2 
Based on #63458.

Co-authored-by: Herrtian <[email protected]>
Signed-off-by: Efe Karasakal <[email protected]>
Signed-off-by: Herrtian <[email protected]>
PR-URL: #64364
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@efekrskl @Herrtian @aduh95
doc: document net Socket server property
3194059 
Based on #63458.

Co-authored-by: Herrtian <[email protected]>
Signed-off-by: Efe Karasakal <[email protected]>
Signed-off-by: Herrtian <[email protected]>
PR-URL: #64364
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
@efekrskl @Herrtian @RafaelGSS
doc: document net Socket server property
b8656c4 
Based on #63458.

Co-authored-by: Herrtian <[email protected]>
Signed-off-by: Efe Karasakal <[email protected]>
Signed-off-by: Herrtian <[email protected]>
PR-URL: #64364
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@efekrskl @Herrtian @aduh95
doc: document net Socket server property