crypto,https,tls: runtime-deprecate OpenSSL engine-based APIs (DEP0183) - #63966
Closed
panva wants to merge 4 commits into
Closed
crypto,https,tls: runtime-deprecate OpenSSL engine-based APIs (DEP0183)#63966panva wants to merge 4 commits into
panva wants to merge 4 commits into
Conversation
Signed-off-by: Filip Skokan <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
panva
marked this pull request as ready for review
June 17, 2026 14:52
panva
added
semver-major
richardlau
approved these changes
Jun 17, 2026
panva
marked this pull request as draft
June 17, 2026 14:56
panva
marked this pull request as ready for review
June 17, 2026 14:56
Renegade334
reviewed
Jun 17, 2026
anonrig
approved these changes
Jun 17, 2026
Renegade334
approved these changes
Jun 17, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
panva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63966 ✔ Done loading data for nodejs/node/pull/63966 ----------------------------------- PR info ------------------------------------ Title crypto,https,tls: runtime-deprecate OpenSSL engine-based APIs (DEP0183) (#63966) Author Filip Skokan <[email protected]> (@panva) Branch panva:runtime-deprecate-DEP0183 -> nodejs:main Labels tls, crypto, semver-major, author ready, deprecations, needs-ci Commits 4 - crypto,https,tls: runtime-deprecate OpenSSL engine-based APIs (DEP0183) - fixup! crypto,https,tls: runtime-deprecate OpenSSL engine-based APIs … - fixup! crypto,https,tls: runtime-deprecate OpenSSL engine-based APIs … - fixup! crypto,https,tls: runtime-deprecate OpenSSL engine-based APIs … Committers 1 - Filip Skokan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63966 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: René <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63966 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: René <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 17 Jun 2026 14:50:48 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/63966#pullrequestreview-4516814071 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/63966#pullrequestreview-4517165427 ✔ - René (@Renegade334): https://github.com/nodejs/node/pull/63966#pullrequestreview-4517285565 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-06-17T20:03:59Z: https://ci.nodejs.org/job/node-test-pull-request/74218/ - Querying data for job/node-test-pull-request/74218/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 63966 From https://github.com/nodejs/node * branch refs/pull/63966/merge -> FETCH_HEAD ✔ Fetched commits as 8fa595456943..640e80379c33 -------------------------------------------------------------------------------- Auto-merging doc/api/crypto.md Auto-merging doc/api/deprecations.md Auto-merging doc/api/tls.md CONFLICT (content): Merge conflict in doc/api/tls.md Auto-merging lib/internal/tls/secure-context.js error: could not apply 6a9bb91648... crypto,https,tls: runtime-deprecate OpenSSL engine-based APIs (DEP0183) hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". hint: Disable this message with "git config set advice.mergeConflict false" ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/27835708140 |
panva
added a commit
that referenced
this pull request
Jun 19, 2026
Signed-off-by: Filip Skokan <[email protected]> PR-URL: #63966 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: René <[email protected]>
Member
Author
|
Landed in da51692 |
panva
removed
the
commit-queue-failed
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/TSC#1869 (comment)