stream: remove transform-writer handling in pipeTo#63684
Open
trivikr wants to merge 1 commit into
Open
Conversation
The pipeTo() and pipeToSync() argument parser already requires the destination argument to be a writer. Remove the later transform-writer handling so writer objects with a transform() method are treated only as destinations. Fixes: nodejs#63683 Signed-off-by: Kamat, Trivikram <[email protected]> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63684 +/- ##
==========================================
- Coverage 90.34% 90.33% -0.02%
==========================================
Files 732 732
Lines 236507 236497 -10
Branches 44531 44526 -5
==========================================
- Hits 213684 213629 -55
- Misses 14525 14584 +59
+ Partials 8298 8284 -14
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unreachable transform-writer handling from
stream/iterpipeTo()andpipeToSync().The argument parser already requires the final non-options argument to be a
writer (
writeforpipeTo(),writeSyncforpipeToSync()). Treating thatsame object as a transform when it also has
transform()does not match thedocumented
pipeTo(source, ...transforms, writer, options?)argument shape.Fixes: #63683
Assisted-by: openai:gpt-5.5