fs: fix glob early return skipping sibling entries - #62901
Closed
semimikoh wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
fs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62901 +/- ##
==========================================
- Coverage 91.55% 89.65% -1.90%
==========================================
Files 355 708 +353
Lines 149381 220407 +71026
Branches 23364 42272 +18908
==========================================
+ Hits 136765 197614 +60849
- Misses 12354 14655 +2301
- Partials 262 8138 +7876
🚀 New features to boost your workflow:
|
ZYSzys
approved these changes
Apr 23, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
semimikoh
force-pushed
the
fix-glob-seen-return
branch
from
April 30, 2026 18:04
cde04e4 to
91565af
Compare
Signed-off-by: semimikoh <[email protected]>
semimikoh
force-pushed
the
fix-glob-seen-return
branch
from
April 30, 2026 18:35
91565af to
4f3a919
Compare
Contributor
Author
|
@ZYSzys Could you re-run CI on this when you get a chance? 🙏 |
github-actions
Bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/72881/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/27184867612 |
Contributor
Author
|
@ZYSzys could you run CI on this? |
trivikr
added
request-ci
github-actions
Bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/72881/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28997064065 |
Contributor
|
Hi @semimikoh, are you still working on this? It looks like CI hasn't passed and there's been no activity for a while. If you don't have time to continue, I'd be happy to take this over and finish the fix (with credit to your work here). Thanks! |
Contributor
Author
|
@trivikr Sure, feel free to take it over and continue the work. Thanks! |
Contributor
|
Thanks @semimikoh Just to confirm I think you meant me (@webdevelopersrinu), as I'm the one who asked above 🙂. I'll take this over, keep your work credited with Co-authored-by, and open a PR with the fix + regression test + green CI. |
Member
|
Superceded by #64895 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache.seencheck from children iteration loop in#addSubpatterns(sync) and#iterateSubpatterns(async)returninside the loop exits the entire method, skipping all remaining siblingscache.addat the top of each method already prevents reprocessing and infinite recursionFixes: #62897
Test plan
test-fs-glob.mjsmultiple times to verify flakiness is resolved