Skip to content

test: use heapdump test for SecureContext memory tracking#62689

Open
mertcanaltin wants to merge 3 commits into
nodejs:mainfrom
mertcanaltin:fix/remove-cctest-memory-tracking
Open

test: use heapdump test for SecureContext memory tracking#62689
mertcanaltin wants to merge 3 commits into
nodejs:mainfrom
mertcanaltin:fix/remove-cctest-memory-tracking

Conversation

@mertcanaltin
Copy link
Copy Markdown
Member

@mertcanaltin mertcanaltin commented Apr 11, 2026

Replace cctest with a heap snapshot test for SecureContext memory tracking.

Refs: #59051

@joyeecheung #59051 (comment)

@mertcanaltin mertcanaltin force-pushed the fix/remove-cctest-memory-tracking branch from fc600de to 8b10dc3 Compare April 11, 2026 09:32
@mertcanaltin mertcanaltin marked this pull request as draft April 11, 2026 09:32
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 11, 2026
@mertcanaltin mertcanaltin force-pushed the fix/remove-cctest-memory-tracking branch from 8b10dc3 to 2f7595c Compare April 11, 2026 09:35
@mertcanaltin mertcanaltin marked this pull request as ready for review April 11, 2026 09:36
@mertcanaltin mertcanaltin force-pushed the fix/remove-cctest-memory-tracking branch from 2f7595c to 9fcc36d Compare April 11, 2026 10:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (726b220) to head (0c3d8b3).
⚠️ Report is 385 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62689      +/-   ##
==========================================
- Coverage   89.81%   89.67%   -0.14%     
==========================================
  Files         699      706       +7     
  Lines      216331   218129    +1798     
  Branches    41355    41736     +381     
==========================================
+ Hits       194294   195606    +1312     
- Misses      14156    14454     +298     
- Partials     7881     8069     +188     

see 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread test/pummel/test-heapdump-secure-context.js Outdated
@mertcanaltin mertcanaltin force-pushed the fix/remove-cctest-memory-tracking branch from 6474bef to a0b2175 Compare April 14, 2026 06:16
Comment thread test/pummel/test-heapdump-secure-context.js Outdated
@mertcanaltin
Copy link
Copy Markdown
Member Author

mertcanaltin commented Apr 15, 2026

I guess, this fail not related this pr

https://github.com/nodejs/node/actions/runs/24399983213/job/71268048969?pr=62689

=== release test-tick-processor-arguments ===
Path: parallel/test-tick-processor-arguments
Error: Command: out/Release/node /Users/runner/work/_temp/node-v26.0.0-nightly2026-04-14840de320c5-slim/test/parallel/test-tick-processor-arguments.js
--- TIMEOUT ---

@H4ad H4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 28, 2026
@joyeecheung joyeecheung added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 28, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 21, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/62689
✔  Done loading data for nodejs/node/pull/62689
----------------------------------- PR info ------------------------------------
Title      test: use heapdump test for SecureContext memory tracking (#62689)
Author     Mert Can Altin <[email protected]> (@mertcanaltin)
Branch     mertcanaltin:fix/remove-cctest-memory-tracking -> nodejs:main
Labels     test, needs-ci, commit-queue-squash
Commits    3
 - test: use heapdump test for SecureContext memory tracking
 - Update test/pummel/test-heapdump-secure-context.js
 - lint
Committers 2
 - Mert Can Altin <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/62689
Refs: https://github.com/nodejs/node/pull/59051
Reviewed-By: Joyee Cheung <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62689
Refs: https://github.com/nodejs/node/pull/59051
Reviewed-By: Joyee Cheung <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 11 Apr 2026 09:32:39 GMT
   ✔  Approvals: 1
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/62689#pullrequestreview-4190781390
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-05-19T15:13:34Z: https://ci.nodejs.org/job/node-test-pull-request/73557/
- Querying data for job/node-test-pull-request/73557/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 62689
From https://github.com/nodejs/node
 * branch                  refs/pull/62689/merge -> FETCH_HEAD
✔  Fetched commits as 614050b657e9..0c3d8b38dc90
--------------------------------------------------------------------------------
[main a7d3ac4078] test: use heapdump test for SecureContext memory tracking
 Author: Mert Can Altin <[email protected]>
 Date: Tue Apr 14 07:16:01 2026 +0100
 2 files changed, 37 insertions(+), 27 deletions(-)
 create mode 100644 test/pummel/test-heapdump-secure-context.js
[main 751dc1c7b4] Update test/pummel/test-heapdump-secure-context.js
 Author: Mert Can Altin <[email protected]>
 Date: Tue Apr 14 10:37:16 2026 +0100
 1 file changed, 6 deletions(-)
[main 7fe04d05d5] lint
 Author: Mert Can Altin <[email protected]>
 Date: Tue Apr 14 13:52:39 2026 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting to fixup everything into first commit.
[main dcc7638a4b] test: use heapdump test for SecureContext memory tracking
 Author: Mert Can Altin <[email protected]>
 Date: Tue Apr 14 07:16:01 2026 +0100
 2 files changed, 31 insertions(+), 27 deletions(-)
 create mode 100644 test/pummel/test-heapdump-secure-context.js
--------------------------------- New Message ----------------------------------
test: use heapdump test for SecureContext memory tracking

PR-URL: #62689
Refs: #59051
Reviewed-By: Joyee Cheung <[email protected]>

[main 58abdcb00b] test: use heapdump test for SecureContext memory tracking
Author: Mert Can Altin <[email protected]>
Date: Tue Apr 14 07:16:01 2026 +0100
2 files changed, 31 insertions(+), 27 deletions(-)
create mode 100644 test/pummel/test-heapdump-secure-context.js
✖ 58abdcb00be449fb388dc18d5186add335cd2478
✔ 0:0 no Assisted-by metadata assisted-by-is-trailer
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Commit must have a "Signed-off-by" trailer signed-off-by
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/26209495744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants