test: use heapdump test for SecureContext memory tracking#62689
Open
mertcanaltin wants to merge 3 commits into
Open
test: use heapdump test for SecureContext memory tracking#62689mertcanaltin wants to merge 3 commits into
mertcanaltin wants to merge 3 commits into
Conversation
fc600de to
8b10dc3
Compare
8b10dc3 to
2f7595c
Compare
2f7595c to
9fcc36d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62689 +/- ##
==========================================
- Coverage 89.81% 89.67% -0.14%
==========================================
Files 699 706 +7
Lines 216331 218129 +1798
Branches 41355 41736 +381
==========================================
+ Hits 194294 195606 +1312
- Misses 14156 14454 +298
- Partials 7881 8069 +188 🚀 New features to boost your workflow:
|
joyeecheung
reviewed
Apr 13, 2026
6474bef to
a0b2175
Compare
joyeecheung
approved these changes
Apr 14, 2026
Co-authored-by: Joyee Cheung <[email protected]>
Member
Author
|
I guess, this fail not related this pr https://github.com/nodejs/node/actions/runs/24399983213/job/71268048969?pr=62689 |
joyeecheung
approved these changes
Apr 28, 2026
Collaborator
Collaborator
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62689 ✔ Done loading data for nodejs/node/pull/62689 ----------------------------------- PR info ------------------------------------ Title test: use heapdump test for SecureContext memory tracking (#62689) Author Mert Can Altin <[email protected]> (@mertcanaltin) Branch mertcanaltin:fix/remove-cctest-memory-tracking -> nodejs:main Labels test, needs-ci, commit-queue-squash Commits 3 - test: use heapdump test for SecureContext memory tracking - Update test/pummel/test-heapdump-secure-context.js - lint Committers 2 - Mert Can Altin <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62689 Refs: https://github.com/nodejs/node/pull/59051 Reviewed-By: Joyee Cheung <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62689 Refs: https://github.com/nodejs/node/pull/59051 Reviewed-By: Joyee Cheung <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 11 Apr 2026 09:32:39 GMT ✔ Approvals: 1 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/62689#pullrequestreview-4190781390 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-05-19T15:13:34Z: https://ci.nodejs.org/job/node-test-pull-request/73557/ - Querying data for job/node-test-pull-request/73557/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 62689 From https://github.com/nodejs/node * branch refs/pull/62689/merge -> FETCH_HEAD ✔ Fetched commits as 614050b657e9..0c3d8b38dc90 -------------------------------------------------------------------------------- [main a7d3ac4078] test: use heapdump test for SecureContext memory tracking Author: Mert Can Altin <[email protected]> Date: Tue Apr 14 07:16:01 2026 +0100 2 files changed, 37 insertions(+), 27 deletions(-) create mode 100644 test/pummel/test-heapdump-secure-context.js [main 751dc1c7b4] Update test/pummel/test-heapdump-secure-context.js Author: Mert Can Altin <[email protected]> Date: Tue Apr 14 10:37:16 2026 +0100 1 file changed, 6 deletions(-) [main 7fe04d05d5] lint Author: Mert Can Altin <[email protected]> Date: Tue Apr 14 13:52:39 2026 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting to fixup everything into first commit. [main dcc7638a4b] test: use heapdump test for SecureContext memory tracking Author: Mert Can Altin <[email protected]> Date: Tue Apr 14 07:16:01 2026 +0100 2 files changed, 31 insertions(+), 27 deletions(-) create mode 100644 test/pummel/test-heapdump-secure-context.js --------------------------------- New Message ---------------------------------- test: use heapdump test for SecureContext memory trackinghttps://github.com/nodejs/node/actions/runs/26209495744 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace cctest with a heap snapshot test for SecureContext memory tracking.
Refs: #59051
@joyeecheung #59051 (comment)