Skip to content

[v24.x backport] WebCryptoAPI digest() updates and new algorithms#62539

Merged
aduh95 merged 2 commits intonodejs:v24.x-stagingfrom
panva:backport-61875-to-24
Apr 3, 2026
Merged

[v24.x backport] WebCryptoAPI digest() updates and new algorithms#62539
aduh95 merged 2 commits intonodejs:v24.x-stagingfrom
panva:backport-61875-to-24

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 1, 2026

Backport of #61875 (modulo the WPT updates that have other dependencies) and #62183

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Apr 1, 2026
@panva panva added the experimental Issues and PRs related to experimental features. label Apr 1, 2026
@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the webcrypto label Apr 1, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 85.90909% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (541be3a) to head (c989497).
⚠️ Report is 2 commits behind head on v24.x-staging.

Files with missing lines Patch % Lines
src/crypto/crypto_turboshake.cc 83.71% 33 Missing and 24 partials ⚠️
src/crypto/crypto_turboshake.h 33.33% 4 Missing ⚠️
lib/internal/crypto/webidl.js 98.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           v24.x-staging   #62539      +/-   ##
=================================================
- Coverage          90.09%   90.06%   -0.03%     
=================================================
  Files                670      672       +2     
  Lines             200740   201174     +434     
  Branches           39231    39304      +73     
=================================================
+ Hits              180847   181197     +350     
- Misses             12166    12240      +74     
- Partials            7727     7737      +10     
Files with missing lines Coverage Δ
lib/internal/crypto/hash.js 98.68% <100.00%> (+0.09%) ⬆️
lib/internal/crypto/mac.js 91.12% <100.00%> (ø)
lib/internal/crypto/util.js 95.49% <100.00%> (+0.06%) ⬆️
src/node_crypto.cc 81.81% <ø> (ø)
lib/internal/crypto/webidl.js 98.41% <98.00%> (+0.08%) ⬆️
src/crypto/crypto_turboshake.h 33.33% <33.33%> (ø)
src/crypto/crypto_turboshake.cc 83.71% <83.71%> (ø)

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@panva panva changed the title [v24.x backport] crypto: rename CShakeParams and KmacParams length to outputLength [v24.x backport] WebCryptoAPI digest() updates and new algorithms Apr 3, 2026
@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Apr 3, 2026
@panva panva force-pushed the backport-61875-to-24 branch from 0667c03 to ee23202 Compare April 3, 2026 08:20
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 force-pushed the backport-61875-to-24 branch from ee23202 to c989497 Compare April 3, 2026 22:05
@aduh95 aduh95 merged commit c989497 into nodejs:v24.x-staging Apr 3, 2026
19 checks passed
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Apr 3, 2026

Landed in 541be3a...c989497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants